Properly report Vertx worker pool size #35483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
geoand
force-pushed
the
#34998
branch
2 times, most recently
from
0ffe08f to
3eb83d8
Compare
|
cc @ahus1 |
This comment has been minimized.
This comment has been minimized.
cescoffier
approved these changes
Aug 23, 2023
geoand
added
the
triage/waiting-for-ci
|
Something seems to be wrong with the devmode tests. I'll have a look tomorrow. |
This comment has been minimized.
This comment has been minimized.
This is done by setting the relevant property in VertxOptions to the size of the Quarkus ExecutorService that is actually by Vertx (in prod mode). The reason we update VertOptions is that PoolMetrics uses it to calculate the blocking pool size. Closes: quarkusio#34998
quarkus-bot
bot
removed
the
triage/waiting-for-ci
|
Thank you @geoand - I only managed to test this today. I built your branch, and created a small demo application. With the default of max threads Although the threads will be started on-demand in the executor and are not really idle, those metrics make sense from the Vert.x facade. LGTM - thank you for this change! |
|
🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done by setting the relevant property
in
VertxOptionsto the size of the QuarkusExecutorService that is actually by Vertx
(in prod mode).
The reason we update
VertxOptionsis thatPoolMetricsuses it to calculate the blockingpool size.
Closes: #34998