-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove devconsole-spi from core #35426
Remove devconsole-spi from core #35426
Conversation
Seems like we still need to ignore the test. I assume it used to pull in the dev-console-spi as transitive dependency. Or I can add those to the quickstart |
This comment has been minimized.
This comment has been minimized.
Waiting on quarkusio/quarkus-quickstarts#1320 |
Signed-off-by: Phillip Kruger <[email protected]>
f6dc9de
to
1a38195
Compare
This comment has been minimized.
This comment has been minimized.
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
@phillip-kruger I might be missing something, but should be something added to the migration guide? |
@famod we will reintroduce the dependency in 3.4. We didn't think it would break so many extensions. @phillip-kruger will create a PR soon. |
@gsmet ah, good to know. Is this just a short-term remedy? Meaning: Does it make sense to add it explicitly in quarkus-cxf regardless? |
No, it doesn't make sense: Quarkus CXF should get rid of using these classes as it's the old Dev Console and it's gone. It's not the only extension affected. So we want this change to be done but we didn't communicate well enough about it, that's why we are reverting it temporarily. |
@gsmet the classes in the spi module is already deprecated. This PR remove all usage from core.