Metaspace improvements in QuarkusUnitTest - round 2 #35407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 17, 2023
This comment has been minimized.
This comment has been minimized.
To avoid memory leaks caused by references to closed threads.
Because LateBoundMDCProvider lives in the AppClassLoader, so it must not reference instances of classes in QuarkusClassLoader after shutdown.
…sks of NioThreadPoolRecorder
Instead of when the proxied class' classloader gets closed, because the proxied class can simply be in the AppClassLoader which never gets closed.
To avoid ClassLoader leaks.
gsmet
force-pushed
the
metaspace-improvement-2
branch
from
315e787 to
bbaa305
Compare
|
I rebased, fixed the formatting issue and force pushed. |
gsmet
approved these changes
Aug 18, 2023
Failing Jobs - Building bbaa305
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 17 Windows #- Failing: integration-tests/mongodb-panache
📦 integration-tests/mongodb-panache✖ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up on #35385
Fixes a few more leaks, though we're not quite where I'd like yet.
I only tested Hibernate ORM deployment tests locally, let's see how it goes on CI.