Dev mode: fix several problems when the initial build fails #35399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mkouba
commented
Aug 17, 2023
mkouba
commented
- IsolatedDevModeMain - replace the default exit handler before the app is created
- previously, if there was a deployment problem then the default exit handler was used; as a result the dev mode exited after the subsequent build failure
- run DevModeListener.afterFirstStart() during restart if the first run did not succeed
- fix FixConfigOnErrorTest - add missing Test annotation
- fix Qute and ArC optimizations to skip generation of certain classes
- fixes dev mode crashes when adding and removing scope producer #35381
- IsolatedDevModeMain - replace the default exit handler _before_ the app is created - previously, if there was a deployment problem then the default exit handler was used; as a result the dev mode exited after the subsequent build failure - run DevModeListener.afterFirstStart() during restart if the first run did not succeed - fix FixConfigOnErrorTest - add missing Test annotation - fix Qute and ArC optimizations to skip generation of certain classes - fixes quarkusio#35381
quarkus-bot
bot
added
area/arc
Ladicek
approved these changes
Aug 17, 2023
manovotn
approved these changes
Aug 17, 2023
This comment has been minimized.
This comment has been minimized.
stuartwdouglas
approved these changes
Aug 17, 2023
cescoffier
approved these changes
Aug 18, 2023
This comment has been minimized.
This comment has been minimized.
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
geoand
approved these changes
Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.