Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable kafka-virtual-threads alert-message test #35398

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Re-enable kafka-virtual-threads alert-message test #35398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...threads/amqp-virtual-threads/src/main/java/io/quarkus/it/vthreads/amqp/PriceConsumer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package io.quarkus.it.vthreads.amqp;

import static io.quarkus.it.vthreads.amqp.AssertHelper.assertThatItDoesNotRunOnVirtualThread;
import static io.quarkus.it.vthreads.amqp.AssertHelper.assertThatItRunsOnADuplicatedContext;
import static io.quarkus.it.vthreads.amqp.AssertHelper.assertThatItRunsOnVirtualThread;

Expand Down Expand Up @@ -34,7 +33,8 @@ public CompletionStage<Void> consume(Message<Double> msg) {
}
return msg.ack().thenAccept(x -> {
assertThatItRunsOnADuplicatedContext();
assertThatItDoesNotRunOnVirtualThread();
// While the ack always runs on event loop thread
// the post-ack may run on the processing virtual-thread which executed the method.
});
}

Expand Down
4 changes: 2 additions & 2 deletions ...reads/kafka-virtual-threads/src/main/java/io/quarkus/it/vthreads/kafka/PriceConsumer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package io.quarkus.it.vthreads.kafka;

import static io.quarkus.it.vthreads.kafka.AssertHelper.assertThatItDoesNotRunOnVirtualThread;
import static io.quarkus.it.vthreads.kafka.AssertHelper.assertThatItRunsOnADuplicatedContext;
import static io.quarkus.it.vthreads.kafka.AssertHelper.assertThatItRunsOnVirtualThread;

Expand Down Expand Up @@ -34,7 +33,8 @@ public CompletionStage<Void> consume(Message<Double> msg) {
}
return msg.ack().thenAccept(x -> {
assertThatItRunsOnADuplicatedContext();
assertThatItDoesNotRunOnVirtualThread();
// While the ack always runs on event loop thread
// the post-ack may run on the processing virtual-thread which executed the method.
});
}

Expand Down
2 changes: 0 additions & 2 deletions ...s/kafka-virtual-threads/src/test/java/io/quarkus/it/vthreads/kafka/VirtualThreadTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
import static com.github.tomakehurst.wiremock.matching.RequestPatternBuilder.newRequestPattern;
import static org.awaitility.Awaitility.await;

import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

import com.github.tomakehurst.wiremock.WireMockServer;
Expand All @@ -29,7 +28,6 @@ void testAlert() {
}

@Test
@Disabled("flaky")
void testAlertMessage() {
await().untilAsserted(() -> mockServer.verify(new CountMatchingStrategy(GREATER_THAN_OR_EQUAL, EXPECTED_CALLS),
newRequestPattern(POST, urlPathEqualTo("/price/alert-message"))));
Expand Down