-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export package from different module name in 23.1-dev #35377
Export package from different module name in 23.1-dev #35377
Conversation
Cancelling CI for now as it is saturated. I will restart this later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a comment that prior 23.1
the class got provided by org.graalvm.sdk
module and with 23.1
onwards, it's provided by the org.graalvm.nativimage
module.
This will have implications on the GraalVM maven dependencies as well once we upgrade to 23.1
.
Module names changed in oracle/graal#7171
c24ce44
to
089940a
Compare
Done
This is a good point, Update: I opened oracle/graal#7224 to ask about it. |
Thanks! Once that's come to a conclusion we need to jot down the actual dependency (maven coordinates) which are now considered API and move to that for the 23.1 GraalVM upgrade. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code change seems fine as it makes Quarkus work with current dev tree of 23.1. So looks good! Thanks.
Failing Jobs - Building 089940a
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 17 Windows #- Failing: extensions/vertx-http/deployment
! Skipped: devtools/cli extensions/agroal/deployment extensions/amazon-lambda-http/deployment and 359 more 📦 extensions/vertx-http/deployment✖
⚙️ Maven Tests - JDK 11 Windows #📦 integration-tests/maven✖
✖
|
Module names changed in oracle/graal#7171