Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export package from different module name in 23.1-dev #35377

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Aug 16, 2023

Module names changed in oracle/graal#7171

@gsmet
Copy link
Member

gsmet commented Aug 16, 2023

Cancelling CI for now as it is saturated. I will restart this later.

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment that prior 23.1 the class got provided by org.graalvm.sdk module and with 23.1 onwards, it's provided by the org.graalvm.nativimage module.

This will have implications on the GraalVM maven dependencies as well once we upgrade to 23.1.

@zakkak zakkak force-pushed the 2023-08-16-fix-module-export-for-23.1 branch from c24ce44 to 089940a Compare August 17, 2023 14:09
@zakkak
Copy link
Contributor Author

zakkak commented Aug 17, 2023

Please add a comment that prior 23.1 the class got provided by org.graalvm.sdk module and with 23.1 onwards, it's provided by the org.graalvm.nativimage module.

Done

This will have implications on the GraalVM maven dependencies as well once we upgrade to 23.1.

This is a good point, com.oracle.svm.core.annotate which is the main package Quarkus uses from graal-sdk.jar has now been moved to nativeimage.jar, although it still gets packaged in graal-sdk.jar transitively we should have a discussion with the GraalVM team to see what the plans about graal-sdk.jar are in the long term.

Update: I opened oracle/graal#7224 to ask about it.

@jerboaa
Copy link
Contributor

jerboaa commented Aug 17, 2023

Update: I opened oracle/graal#7224 to ask about it.

Thanks! Once that's come to a conclusion we need to jot down the actual dependency (maven coordinates) which are now considered API and move to that for the 23.1 GraalVM upgrade.

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change seems fine as it makes Quarkus work with current dev tree of 23.1. So looks good! Thanks.

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 17, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 17, 2023

Failing Jobs - Building 089940a

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 Windows Build Failures Logs Raw logs
JVM Tests - JDK 20 Build ⚠️ Check → Logs Raw logs
✔️ Maven Tests - JDK 11
Maven Tests - JDK 11 Windows Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 Windows #

- Failing: extensions/vertx-http/deployment 
! Skipped: devtools/cli extensions/agroal/deployment extensions/amazon-lambda-http/deployment and 359 more

📦 extensions/vertx-http/deployment

io.quarkus.vertx.http.testrunner.includes.IncludePatternTestCase.checkTestsAreRun line 53 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Failed to wait for test run 2 State{lastRun=1, running=true, inProgress=true, run=1, passed=1, failed=0, skipped=0, isBrokenOnly=false, isTestOutput=false, isInstrumentationBasedReload=false, isLiveReload=true}
	at io.quarkus.test.ContinuousTestingTestUtils.waitForNextCompletion(ContinuousTestingTestUtils.java:44)
	at io.quarkus.vertx.http.testrunner.includes.IncludePatternTestCase.checkTestsAreRun(IncludePatternTestCase.java:53)

⚙️ Maven Tests - JDK 11 Windows #

📦 integration-tests/maven

io.quarkus.maven.it.JarRunnerIT.testPlatformPropertiesOverridenInApplicationProperties line 135 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.JarRunnerIT that uses io.quarkus.maven.it.verifier.MavenProcessInvocationResult was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

io.quarkus.maven.it.JarRunnerIT.testPlatformPropertiesOverridenInApplicationProperties line 135 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.JarRunnerIT that uses io.quarkus.maven.it.verifier.MavenProcessInvocationResult was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants