Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include stars badge in README.md #35330

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Include stars badge in README.md #35330

merged 1 commit into from
Aug 15, 2023

Conversation

shivam-sharma7
Copy link
Contributor

@shivam-sharma7 shivam-sharma7 commented Aug 12, 2023

Preview

image

@shivam-sharma7
Copy link
Contributor Author

shivam-sharma7 commented Aug 12, 2023

@maxandersen @gsmet @gastaldi

@gastaldi
Copy link
Contributor

gastaldi commented Aug 12, 2023

Cool, but I'd prefer having a single badge showing how many stars the repository has instead.

Eg. GitHub Repo stars

@shivam-sharma7
Copy link
Contributor Author

Cool, but I'd prefer having a single badge showing how many stars the repository has instead.

Eg. GitHub Repo stars

@gastaldi should I add this in same place or on the Top where all badges are present?

@gastaldi
Copy link
Contributor

Probably next to the other badges, with the same Look'n Feel

@shivam-sharma7
Copy link
Contributor Author

@gastaldi see

README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pease squash your commits before we merge this

README.md Outdated Show resolved Hide resolved
@gastaldi
Copy link
Contributor

LGTM, but I think the commit and the PR title need to be reworded?

@shivam-sharma7
Copy link
Contributor Author

LGTM, but I think the commit and the PR title need to be reworded?

@gastaldi any suggetion for commit and tittle

@gastaldi
Copy link
Contributor

How about Include stars badge in README.md? 😄

@shivam-sharma7 shivam-sharma7 changed the title Add Stargazers in Readme.md Include stars badge in README.md Aug 15, 2023
@shivam-sharma7
Copy link
Contributor Author

@gastaldi done!

@gastaldi gastaldi merged commit e6391b6 into quarkusio:main Aug 15, 2023
@quarkus-bot quarkus-bot bot added this to the 3.4 - main milestone Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants