-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use SmallRyeConfigBuilder Customizer to generate Quarkus configuration #35322
Conversation
e1ac0c8
to
5b550e9
Compare
f9d2248
to
70ab0ee
Compare
This comment has been minimized.
This comment has been minimized.
70ab0ee
to
db75685
Compare
This comment has been minimized.
This comment has been minimized.
db75685
to
793fdc1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quickly taken a look, great Roberto!
This comment has been minimized.
This comment has been minimized.
793fdc1
to
9e2d1d0
Compare
This comment has been minimized.
This comment has been minimized.
9e2d1d0
to
b2ba603
Compare
This comment has been minimized.
This comment has been minimized.
b2ba603
to
4c2706a
Compare
This comment has been minimized.
This comment has been minimized.
@radcortez it seems you're using a Mac, which does not provide a case sensitive volume by default. See the discussion in Zulip and #36180 (comment) |
4c2706a
to
b138908
Compare
When I did a rebase, I noticed that file, but I thought it was just code-style formatting applied by the build. |
This comment has been minimized.
This comment has been minimized.
b138908
to
1d65999
Compare
This comment has been minimized.
This comment has been minimized.
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
@@ -23,7 +22,6 @@ public interface ConfigConfig { | |||
/** | |||
* Profile that will be active when Quarkus launches. | |||
*/ | |||
@WithDefault("prod") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see how we wouldn't want a default for an Optional but do you confirm this doesn't change our behavior?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is fine because the profile was always being overridden by the launch mode:
https://github.com/quarkusio/quarkus/pull/35322/files#diff-11168005e2c503c75c2ff0f927c06e4ca8fb9676b91d58e37ea98b05d68cc27dR29
So, there's no point in setting it here. Also, it would show up as the default in the docs, and because the profile changes depending on the launch mode, it doesn't make sense either to show a default profile in there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for confirming! Let's get this in then.
Switch to DefaultValuesConfigSource after quarkusio/quarkus#35322
Switch to DefaultValuesConfigSource after quarkusio/quarkus#35322
These are significant changes, with the following goals:
Customizer
and removing all individual components registration in the generatorUsed
config-quickstart
to measure improvements with Java 17 Temurin and Graal 22.3 - Java 17:Overall, this PR, should show startup time and RSS improvements for every Quarkus application (at scale), since the improvements affect the core, which always executes regardless of which extensions are available.