Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old Dev UI: Extension and Core #35317

Merged

Conversation

phillip-kruger
Copy link
Member

@phillip-kruger phillip-kruger commented Aug 11, 2023

This removes the final bit of the Old Dev UI

fix #34206

@quarkus-bot

This comment has been minimized.

@phillip-kruger phillip-kruger force-pushed the dev-ui-remove-extensions branch from 2c4fe29 to 60653cd Compare August 11, 2023 04:00
@phillip-kruger phillip-kruger mentioned this pull request Aug 11, 2023
42 tasks
@quarkus-bot

This comment has been minimized.

@phillip-kruger
Copy link
Member Author

Once this rebase on the arc PR we should be ok

</dependency>
<dependency>
<groupId>org.webjars</groupId>
<artifactId>jquery</artifactId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break the logging manager extension again right? I suppose you will fix it later?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. the idea is to remove the ui from the logging manager extension, and work on enable the logging in prod mode as part of an effort to allow certain things in prod mode

@gsmet
Copy link
Member

gsmet commented Aug 16, 2023

Awesome \o/

In the end, did we migrate the Kafka Streams Dev UI? I don't remember seeing it but I might have missed it.

@phillip-kruger
Copy link
Member Author

re: kafka streams, no not migrated. i'll look at it at some point

@quarkus-bot

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Aug 16, 2023

I would recommend to at least run mvn -Dquickly locally before pushing.

@phillip-kruger
Copy link
Member Author

I did ?!? Let me check again

@phillip-kruger
Copy link
Member Author

I might have to clear my m2 cache

@phillip-kruger
Copy link
Member Author

@gsmet - Yea so removing m2 cache recreated this on local. Building fine on local now, lets see what CI says.

@quarkus-bot

This comment has been minimized.

Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Once this is merged, we need to check out the virtual server (and maybe it will fix funqy in dev mode with the dev UI)

@phillip-kruger
Copy link
Member Author

Thanks @cescoffier ! Seems I need to fix a quickstart first. I'll look at that in the morning

@quarkus-bot

This comment has been minimized.

@phillip-kruger phillip-kruger force-pushed the dev-ui-remove-extensions branch 2 times, most recently from dbaf24b to 78068f4 Compare August 18, 2023 11:32
@phillip-kruger
Copy link
Member Author

I have to revert the commit that removed the dev-console modules. I'll do another PR for that. We need to remove some stuff in optaplanner first as we get an error with the quickstarts build in CI

@phillip-kruger phillip-kruger added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 18, 2023
@gsmet
Copy link
Member

gsmet commented Aug 18, 2023

@phillip-kruger let's do that in another PR but given OptaPlanner is not part of the Platform anymore, we can probably disable the quickstart for now.

@phillip-kruger
Copy link
Member Author

Cool

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@phillip-kruger phillip-kruger force-pushed the dev-ui-remove-extensions branch from 78068f4 to 19aae16 Compare August 19, 2023 07:33
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 19, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@phillip-kruger phillip-kruger merged commit bc8e5b0 into quarkusio:main Aug 19, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 19, 2023
@quarkus-bot quarkus-bot bot added this to the 3.4 - main milestone Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removal of the old Dev UI
3 participants