-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old Dev UI: Extension and Core #35317
Remove old Dev UI: Extension and Core #35317
Conversation
This comment has been minimized.
This comment has been minimized.
2c4fe29
to
60653cd
Compare
This comment has been minimized.
This comment has been minimized.
Once this rebase on the arc PR we should be ok |
60653cd
to
eca4054
Compare
</dependency> | ||
<dependency> | ||
<groupId>org.webjars</groupId> | ||
<artifactId>jquery</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will break the logging manager extension again right? I suppose you will fix it later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. the idea is to remove the ui from the logging manager extension, and work on enable the logging in prod mode as part of an effort to allow certain things in prod mode
Awesome \o/ In the end, did we migrate the Kafka Streams Dev UI? I don't remember seeing it but I might have missed it. |
re: kafka streams, no not migrated. i'll look at it at some point |
This comment has been minimized.
This comment has been minimized.
I would recommend to at least run |
I did ?!? Let me check again |
I might have to clear my m2 cache |
a60d59a
to
ab95536
Compare
ab95536
to
19ed8e4
Compare
@gsmet - Yea so removing m2 cache recreated this on local. Building fine on local now, lets see what CI says. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Once this is merged, we need to check out the virtual server (and maybe it will fix funqy in dev mode with the dev UI)
Thanks @cescoffier ! Seems I need to fix a quickstart first. I'll look at that in the morning |
This comment has been minimized.
This comment has been minimized.
dbaf24b
to
78068f4
Compare
I have to revert the commit that removed the dev-console modules. I'll do another PR for that. We need to remove some stuff in optaplanner first as we get an error with the quickstarts build in CI |
@phillip-kruger let's do that in another PR but given OptaPlanner is not part of the Platform anymore, we can probably disable the quickstart for now. |
Cool |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Phillip Kruger <[email protected]>
78068f4
to
19aae16
Compare
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
This removes the final bit of the Old Dev UI
fix #34206