Warn about unknown application config files #35298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
radcortez
commented
Aug 9, 2023
radcortez
commented
- Fixes warn or fail if an application.yaml is provided without the quarkus-config-yaml dependency #13227
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
gsmet
requested changes
Aug 11, 2023
| reflectiveClass.produce(ReflectiveClassBuildItem.builder(URI.class).constructors(true).build()); | ||
| // No need to include the application files, because they don't change | ||
| if (!launchModeBuildItem.getLaunchMode().isDevOrTest()) { | ||
| configRecorder.unknownConfigFiles(); |
There was a problem hiding this comment.
So you want to log it once at build time and one at runtime, right?
There was a problem hiding this comment.
Yes, because this also looks into the config folder and quarkus.config.locations, which may be different from build to runtime, so we need to perform the checks twice.
core/deployment/src/main/java/io/quarkus/deployment/steps/ConfigGenerationBuildStep.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
gsmet
approved these changes
Sep 22, 2023
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.