Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QuarkusComponentTest: test config source ordinal improvements #35202

Merged
merged 1 commit into from
Aug 7, 2023
Merged

QuarkusComponentTest: test config source ordinal improvements #35202

merged 1 commit into from
Aug 7, 2023

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Aug 4, 2023

@mkouba mkouba requested a review from holly-cummins August 4, 2023 10:35
@quarkus-bot

This comment has been minimized.

Sign in to view
holly-cummins
holly-cummins approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@holly-cummins holly-cummins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The priority ordinal isn't something I know a great deal about, but LGTM :)

@mkouba
Copy link
Contributor Author

mkouba commented Aug 4, 2023

The priority ordinal isn't something I know a great deal about, but LGTM :)

So the main motivation for this change (275 -> 500) is that if you use QuarkusTestProfile.getConfigOverrides() to override property foo then a system property of name foo is set and currently takes precedence over @TestConfigProperty(key = "foo"). As a result the value used for a QuarkusComponentTest depends on the test ordering which is very 👎 .

@mkouba mkouba requested a review from radcortez August 5, 2023 12:30
@mkouba
QuarkusComponentTest: test config source ordinal improvements
3615a71 
- change the default value to 500 so that test config properties take
predence over system properties, ENV variables and
application.properties
- make the ordinal configurable
- fixes quarkusio#35199
@mkouba mkouba requested a review from manovotn August 7, 2023 07:42
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 7, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@manovotn manovotn merged commit 772d5e1 into quarkusio:main Aug 7, 2023
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Aug 7, 2023
@quarkus-bot quarkus-bot bot added this to the 3.3 - main milestone Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holly-cummins holly-cummins holly-cummins approved these changes

@radcortez radcortez radcortez approved these changes

@manovotn manovotn manovotn approved these changes

Assignees
No one assigned
Labels
area/testing kind/enhancement New feature or request
Projects
None yet
Milestone
3.3.0.CR1
Development

Successfully merging this pull request may close these issues.

QuarkusComponentTest: make is possible to specify priority of a test config property
4 participants
@mkouba @manovotn @radcortez @holly-cummins