Wire extension updates in quarkus update #35191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/devtools
|
@gsmet nice, this is exactly what I had in mind! Thanks this is one less thing in my todo list :) |
|
@aloubyansky could you have a look at this one? I think we will want it in 3.2 maybe. |
This comment has been minimized.
This comment has been minimized.
aloubyansky
reviewed
Aug 11, 2023
| for (ExtensionUpdateInfo nonPlatformExtensionsUpdate : nonPlatformExtensionsUpdates) { | ||
| if (nonPlatformExtensionsUpdate.getCurrentDep().isPlatformExtension()) { | ||
| // add, my understanding is that we should define the version? As a dependency, as a managed one? | ||
| // not completely sure how to make it work for a multi-module project? |
There was a problem hiding this comment.
Should we log something in this case? AFAIU, we are not applying any update in this case.
| // not completely sure how to make it work for a multi-module project? | ||
| } else if (nonPlatformExtensionsUpdate.getRecommendedDependency().isPlatformExtension()) { | ||
| // remove, decide what to do here, should we remove the version given it is now managed? Will OpenRewrite support that? | ||
| // not completely sure how to make it work for a multi-module project? |
Note that this is a preliminar effort and it is not handling all the possibilities. Handling the other possibilities might be problematic given how we apply the recipes to a root module of a multi-module project.
gsmet
force-pushed
the
wire-extension-updates
branch
from
5ed04ce to
53219e6
Compare
|
@aloubyansky I think we should get this one in even if not perfect. I'm not sure I fully understand the two other cases so if you want something logged you would have to finish this. |
|
Ok, those are not usual cases. |
aloubyansky
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a relatively naive and simple approach but it seems to work OK.
Note that this is a preliminar effort and it is not handling all the
possibilities.
Handling the other possibilities might be problematic given how we apply
the recipes to a root module of a multi-module project.
@aloubyansky I would be interested in your feedback.
/cc @ia3andy @aloubyansky