-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce allocation cost reporting spans #35183
Conversation
/cc @brunobat (opentelemetry), @radcortez (opentelemetry) |
Just to better understand this change... Will the Buffer be reused inside vert.x thus reducing the allocation needs? |
This comment has been minimized.
This comment has been minimized.
btw, main is broken. Failure in dev-ui-resources is unrelated. |
Inside Vert.x / Netty, it will. However currently, the buffer is not pooled, meaning that each reporting of Spans will result in the allocation of a new memory segment. |
Yup, unfortunately |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This is done by leveraging Vert.x's Buffer directly instead of relying on a ByteArrayOutputStream
Failing Jobs - Building d603488
Failures⚙️ JVM Tests - JDK 17 Windows #- Failing: extensions/vertx-http/deployment
! Skipped: extensions/agroal/deployment extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment and 358 more 📦 extensions/vertx-http/deployment✖ |
This is done by leveraging Vert.x's
Buffer
directly instead of relying on a
ByteArrayOutputStream