-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce HTTP OTLP exporter #35156
Introduce HTTP OTLP exporter #35156
Conversation
/cc @brunobat (opentelemetry), @radcortez (opentelemetry) |
@yrodiere I am seeing:
in the main integration test and it should be completely unrelated to this PR (or at least I don't see how it could be related) |
I'm back from two weeks out of office, so take this with a grain of salt, but all I can say is that I didn't see any change related to H2 recently, nor did I ever see any use of Lucene in Quarkus Core (let alone H2). I suppose your changes might be introducing code that makes GraalVM think that But be aware there is (used to be?) a bug in GraalVM in which the firsts static init error was ignored and GraalVM still proceeds and generates tons of seemingly nonsensical errors as a result. See oracle/graal#6368 I can have a look at some point, but I hope it's not too urgent as I'm still catching up with emails and (lots of) PRs that I need to review to get others unstuck. EDIT: FWIW there's also this entry in H2's |
Ah wait, I'm seeing this elsewhere, so it's not limited to this PR. I guess I know what I'll do with my day :) |
The caused seems to be there: #34615 (comment) |
Thanks for the super quick investigation! |
.../java/io/quarkus/opentelemetry/runtime/config/runtime/exporter/OtlpExporterTracesConfig.java
Outdated
Show resolved
Hide resolved
.../java/io/quarkus/opentelemetry/runtime/config/runtime/exporter/OtlpExporterTracesConfig.java
Outdated
Show resolved
Hide resolved
.../runtime/src/main/java/io/quarkus/opentelemetry/runtime/exporter/otlp/VertxHttpExporter.java
Show resolved
Hide resolved
The integration utilizes the HttpSender interface introduced in OTel 1.28 and is based on the Vert.x HTTP Client
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks @geoand !
🙏🏼 |
This comment has been minimized.
This comment has been minimized.
@geoand Could you pls open PR for docs? |
@rsvoboda not sure what you are asking for |
This is new feature/enhancement, bu this PR didn't add anything into docs/guides. |
That's probably best done by @brunobat who has all the OpenTelemetry context |
I already did here: PS: PR #35465 |
Thanks Bruno. We have a note, should be good for now. It can be extended if people need more details. |
The integration utilizes the
HttpSender
interface introduced in OTel 1.28
and is based on the Vert.x HTTP Client
Closes: #21535