Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Config APIs #35150

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

radcortez
Copy link
Member

No description provided.

@quarkus-bot

This comment has been minimized.

@gsmet gsmet force-pushed the config-remove-deprecated branch from 7ae9153 to bf77189 Compare August 2, 2023 07:30
@geoand
Copy link
Contributor

geoand commented Aug 2, 2023

Are we sure the bootstrap stuff is not used anymore in any Quarkiverse extensions?

If they are still being used, we should probably reach out and offer suggestions on the fix.

Also, an email to quarkus-dev is probably warranted

@radcortez
Copy link
Member Author

Are we sure the bootstrap stuff is not used anymore in any Quarkiverse extensions?

If they are still being used, we should probably reach out and offer suggestions on the fix.

I've rewrote and pushed PR's to places I knew that used it.

Also, an email to quarkus-dev is probably warranted

I can send an email.

@gastaldi
Copy link
Contributor

gastaldi commented Aug 2, 2023

Just a reminder that the quarkus-ecosystem-ci will also warn if a Quarkiverse extension uses the bootstrap stuff

@gastaldi gastaldi merged commit 4e0fac1 into quarkusio:main Aug 2, 2023
@quarkus-bot quarkus-bot bot added this to the 3.3 - main milestone Aug 2, 2023
@famod
Copy link
Member

famod commented Aug 8, 2023

FYI, #35261 removes the deleted IT module also from the native tests json.

@radcortez radcortez deleted the config-remove-deprecated branch September 8, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants