Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase DevMojoIT#testResourcesFromClasspath timeout #35146

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

gastaldi
Copy link
Contributor

@gastaldi gastaldi commented Aug 1, 2023

Increasing the timeout makes the test pass in Windows

@gastaldi gastaldi requested a review from aloubyansky August 1, 2023 15:56
@gastaldi gastaldi changed the title Increase DevMojoIT#testResourcesClasspath timeout Increase DevMojoIT#testResourcesFromClasspath timeout Aug 1, 2023
@@ -41,3 +41,4 @@ nb-configuration.xml
.envrc
.jekyll-cache
.mvn/.gradle-enterprise
.quarkus
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was this for?

Copy link
Contributor Author

@gastaldi gastaldi Aug 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I ran the test, a .quarkus/cli/plugins/quarkus-catalog.json is created in the root, see 558aadf

@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 1, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 2, 2023

Failing Jobs - Building 7c1e797

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 17
JVM Tests - JDK 20 Build ⚠️ Check → Logs Raw logs
✔️ Maven Tests - JDK 11
Maven Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
Native Tests - Data2 Build ⚠️ Check → Logs Raw logs

@gastaldi gastaldi merged commit 1e60d82 into quarkusio:main Aug 2, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 2, 2023
@gastaldi gastaldi deleted the devmojo_windows branch August 2, 2023 02:18
@quarkus-bot quarkus-bot bot added this to the 3.3 - main milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants