-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow customizing ObjectReader via @CustomDeserialization
in Resteasy
#35138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To customize the `com.fasterxml.jackson.databind.ObjectReader` to read JSON requests with unquoted field names: ```java @CustomDeserialization(SupportUnquotedFields.class) @post @path("/use-of-custom-deserializer") public void useOfCustomSerializer(User request) { // ... } ``` where `SupportUnquotedFields` is a `BiFunction` defined as so: ```java public static class SupportUnquotedFields implements BiFunction<ObjectMapper, Type, ObjectReader> { @OverRide public ObjectReader apply(ObjectMapper objectMapper, Type type) { return objectMapper.reader().with(JsonReadFeature.ALLOW_UNQUOTED_FIELD_NAMES); } } ```
I am going to remove the |
geoand
approved these changes
Aug 1, 2023
geoand
reviewed
Aug 1, 2023
...ackson/runtime/src/main/java/io/quarkus/resteasy/reactive/jackson/CustomDeserialization.java
Show resolved
Hide resolved
geoand
added
the
triage/waiting-for-ci
Ready to merge when CI successfully finishes
label
Aug 1, 2023
🙈 The PR is closed and the preview is expired. |
Failing Jobs - Building 3cda45d
Full information is available in the Build summary check run. Failures⚙️ Virtual Thread Support Tests Native - Messaging #📦 kafka-virtual-threads✖
✖
|
I think the test failures are unrelated |
Yup |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Ready to merge when CI successfully finishes
label
Aug 2, 2023
Sgitario
added a commit
to Sgitario/quarkus
that referenced
this pull request
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To customize the
com.fasterxml.jackson.databind.ObjectReader
to read JSON requests with unquoted field names:where
SupportUnquotedFields
is aBiFunction
defined as so:Fix #35122