Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom AMQP dev service images #35127

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Add support for custom AMQP dev service images #35127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion docs/src/main/asciidoc/amqp-dev-services.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,4 +51,8 @@ You can configure the image and version using the `quarkus.amqp.devservices.imag
[source, properties]
----
quarkus.amqp.devservices.image-name=quay.io/artemiscloud/activemq-artemis-broker:latest
----
----

IMPORTANT: The configured image must be _compatible_ with the `activemq-artemis-broker` one.
The container is launched with the `AMQ_USER`, `AMQ_PASSWORD` and `AMQ_EXTRA_ARGS` environment variables.
The ports 5672 and 8161 (web console) are exposed.
7 changes: 6 additions & 1 deletion .../java/io/quarkus/smallrye/reactivemessaging/amqp/deployment/AmqpDevServicesProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,12 @@ private ArtemisContainer(DockerImageName dockerImageName, String extra, int fixe
if (dockerImageName.getRepository().endsWith("artemiscloud/activemq-artemis-broker")) {
waitingFor(Wait.forLogMessage(".*AMQ241004.*", 1)); // Artemis console available.
} else {
throw new IllegalArgumentException("Only artemiscloud/activemq-artemis-broker images are supported");
log.infof(
"Detected a different image (%s) for the Dev Service for AMQP. Ensure it's compatible with artemiscloud/activemq-artemis-broker. "
+
"Refer to https://quarkus.io/guides/amqp-dev-services#configuring-the-image for details.",
dockerImageName);
log.info("Skipping startup probe for the Dev Service for AMQP as it does not use the default image.");
}
}

Expand Down