-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Virtual threads module providing executor supplier for running virtual threads #35069
Merged
cescoffier
merged 1 commit into
quarkusio:main
from
ozangunalp:virtual_threads_executor_extension
Aug 1, 2023
Merged
Virtual threads module providing executor supplier for running virtual threads #35069
cescoffier
merged 1 commit into
quarkusio:main
from
ozangunalp:virtual_threads_executor_extension
Aug 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/dependencies
Pull requests that update a dependency file
area/devtools
Issues/PR related to maven, gradle, platform and cli tooling/plugins
area/documentation
area/grpc
gRPC
area/reactive-messaging
area/rest
area/smallrye
labels
Jul 27, 2023
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
cescoffier
requested changes
Jul 28, 2023
...e/src/main/java/io/quarkus/smallrye/reactivemessaging/runtime/QuarkusWorkerPoolRegistry.java
Outdated
Show resolved
Hide resolved
...ual-threads/deployment/src/main/java/io/quarkus/virtual/threads/VirtualThreadsProcessor.java
Outdated
Show resolved
Hide resolved
...reads/runtime/src/main/java/io/quarkus/virtual/threads/ContextPreservingExecutorService.java
Show resolved
Hide resolved
...s/virtual-threads/runtime/src/main/java/io/quarkus/virtual/threads/VirtualThreadsConfig.java
Show resolved
Hide resolved
...s/virtual-threads/runtime/src/main/java/io/quarkus/virtual/threads/VirtualThreadsConfig.java
Outdated
Show resolved
Hide resolved
...virtual-threads/runtime/src/main/java/io/quarkus/virtual/threads/VirtualThreadsRecorder.java
Show resolved
Hide resolved
...virtual-threads/runtime/src/main/java/io/quarkus/virtual/threads/VirtualThreadsRecorder.java
Show resolved
Hide resolved
...virtual-threads/runtime/src/main/java/io/quarkus/virtual/threads/VirtualThreadsRecorder.java
Outdated
Show resolved
Hide resolved
...virtual-threads/runtime/src/main/java/io/quarkus/virtual/threads/VirtualThreadsRecorder.java
Outdated
Show resolved
Hide resolved
ozangunalp
force-pushed
the
virtual_threads_executor_extension
branch
from
July 28, 2023 16:25
05504f5
to
1e2b68b
Compare
This comment has been minimized.
This comment has been minimized.
cescoffier
approved these changes
Jul 31, 2023
Can you rebase and see if the CI issues are related (hopefully not) |
…tual threads - Handles executor close on shutdown hook - Creates named virtual threads
ozangunalp
force-pushed
the
virtual_threads_executor_extension
branch
from
July 31, 2023 07:26
1e2b68b
to
3be4c1a
Compare
Rebased |
ozangunalp
added
the
triage/waiting-for-ci
Ready to merge when CI successfully finishes
label
Jul 31, 2023
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Ready to merge when CI successfully finishes
label
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/dependencies
Pull requests that update a dependency file
area/devtools
Issues/PR related to maven, gradle, platform and cli tooling/plugins
area/documentation
area/grpc
gRPC
area/reactive-messaging
area/rest
area/smallrye
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces ad-hoc virtual thread executors in resteasy-reactive, grpc and reactive messaging
Handles executor service close on shutdown hook
Creates named virtual threads
Introduces config options:
quarkus.virtual-threads.name-prefix
defaultquarkus-virtual-thread-
quarkus.virtual-threads.shutdown-timeout
default 1 minutequarkus.virtual-threads.shutdown-check-interval
default 5 seconds