Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual threads module providing executor supplier for running virtual threads #35069

Merged

Conversation

ozangunalp
Copy link
Contributor

Replaces ad-hoc virtual thread executors in resteasy-reactive, grpc and reactive messaging
Handles executor service close on shutdown hook
Creates named virtual threads
Introduces config options:

  • quarkus.virtual-threads.name-prefix default quarkus-virtual-thread-
  • quarkus.virtual-threads.shutdown-timeout default 1 minute
  • quarkus.virtual-threads.shutdown-check-interval default 5 seconds

@ozangunalp ozangunalp requested a review from cescoffier July 27, 2023 18:02
@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/grpc gRPC area/reactive-messaging area/rest area/smallrye labels Jul 27, 2023
@github-actions
Copy link

github-actions bot commented Jul 27, 2023

🙈 The PR is closed and the preview is expired.

@quarkus-bot

This comment has been minimized.

@ozangunalp ozangunalp force-pushed the virtual_threads_executor_extension branch from 05504f5 to 1e2b68b Compare July 28, 2023 16:25
@quarkus-bot

This comment has been minimized.

@cescoffier
Copy link
Member

Can you rebase and see if the CI issues are related (hopefully not)

…tual threads

- Handles executor close on shutdown hook
- Creates named virtual threads
@ozangunalp ozangunalp force-pushed the virtual_threads_executor_extension branch from 1e2b68b to 3be4c1a Compare July 31, 2023 07:26
@ozangunalp
Copy link
Contributor Author

Rebased

@ozangunalp ozangunalp added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 31, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 31, 2023

Failing Jobs - Building 3be4c1a

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 17
✔️ JVM Tests - JDK 20
✔️ Maven Tests - JDK 11
Maven Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs

@cescoffier cescoffier merged commit afcf7b2 into quarkusio:main Aug 1, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 1, 2023
@quarkus-bot quarkus-bot bot added this to the 3.3 - main milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/grpc gRPC area/reactive-messaging area/rest area/smallrye
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants