Generate/use pull secrets when possible #35036
Conversation
|
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
gsmet
changed the title
This comment has been minimized.
This comment has been minimized.
| /** | ||
| * Enable generation of image pull secret, when credentials are available. | ||
| */ | ||
| @ConfigItem(defaultValue = "true") |
There was a problem hiding this comment.
I would disable this property by default, since it should not be used for security reasons.
| * Enable generation of image pull secret, when credentials are available. | ||
| */ | ||
| @ConfigItem(defaultValue = "true") | ||
| boolean imagePullSecretGenerate; |
There was a problem hiding this comment.
About the name, I would rename it to generate-image-pull-secret instead to follow the same pattern as others properties like quarkus.kubernetes-client.generate-rbac.
| @@ -183,6 +183,12 @@ public static enum DeploymentResourceKind { | |||
| @ConfigItem | |||
| Optional<List<String>> imagePullSecrets; | |||
|
|
|||
| /** | |||
| * Enable generation of image pull secret, when credentials are available. | |||
There was a problem hiding this comment.
| * Enable generation of image pull secret, when credentials are available. | |
| * Enable generation of image pull secret, when the container image username and password were provided. |
Or something like this.
iocanel
force-pushed
the
push-pull-secret-handling
branch
from
7aee675 to
60b2237
Compare
|
🙈 The PR is closed and the preview is expired. |
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
Inspirted by @Sgitario comment on #34241 this pull request automates the generation of image pull secrets when registry and credentials are provided as part of a push operation.