Gradle plugin: optionally respect non-quarkus.* cache-relevant properties
#35003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/devtools
snazy
force-pushed
the
relevant-build-env-vars
branch
from
b777b17 to
d08728b
Compare
|
/cc @gsmet |
snazy
force-pushed
the
relevant-build-env-vars
branch
from
d08728b to
386dce9
Compare
|
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
…erties
Currently the Gradle plugin considers only system properties starting with `quarkus.` (and env vars starting with `QUARKUS_`) as relevant for Gradle's cache key. This is on purpose to not cause unnecessary rebuilds, because especially system properties can contain entries that are rather "random-ish". But other environment variables or system properties cannot be specified as "relevant".
This change introduces a new list-property `cachingRelevantProperties` on the Quarkus Gradle extension object to tell the Quarkus Gradle plugin to consider the specified properties/env-vars as input(s) for the tasks. This list-property accepts regex patterns, and by default contains `quarkus[.].*`, matching the current `.startsWith("quarkus.")`.
Fixes quarkusio#34869
snazy
force-pushed
the
relevant-build-env-vars
branch
from
386dce9 to
44b76fa
Compare
|
Although this change introduces a new property on the extension object, it's probably worth backporting this to 3.2 (should apply cleanly). |
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
|
@aloubyansky this one seems to have fallen through the cracks. |
aloubyansky
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the Gradle plugin considers only system properties starting with
quarkus.(and env vars starting withQUARKUS_) as relevant for Gradle's cache key. This is on purpose to not cause unnecessary rebuilds, because especially system properties can contain entries that are rather "random-ish". But other environment variables or system properties cannot be specified as "relevant".This change introduces a new list-property
cachingRelevantPropertieson the Quarkus Gradle extension object to tell the Quarkus Gradle plugin to consider the specified properties/env-vars as input(s) for the tasks. This list-property accepts regex patterns, and by default containsquarkus[.].*, matching the current.startsWith("quarkus.").Fixes #34869