Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Synthetic bean for producing OpenTelemetry #34990

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jul 25, 2023

This will make the bean production even more
resilient to timing issues

This should be the last round of refactoring around OTel bean production

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 25, 2023

/cc @brunobat (opentelemetry), @radcortez (opentelemetry)

This will make the bean production even more
resilient to timing issues
@geoand geoand force-pushed the OpenTelemetry-synthetic branch from c54e618 to 09cd879 Compare July 25, 2023 08:19
Copy link
Contributor

@brunobat brunobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks beautiful :)

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 25, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 25, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@geoand geoand merged commit d2ed11f into quarkusio:main Jul 25, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 25, 2023
@geoand geoand deleted the OpenTelemetry-synthetic branch July 25, 2023 11:11
@quarkus-bot quarkus-bot bot added this to the 3.3 - main milestone Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants