Add a way to configure an OpenSearch distribution for the Elasticsearch DevService

[marko-bekhta]

Fixes #23906

This was among the things Yoann suggested to look into. While doing so, I noticed that the guide had property placeholders instead of values -- fixed that.

Also, I wanted to better understand the logic behind the used Elasticsearch/OpenSearch image versions, but couldn't figure it out 😃 so any pointers are appreciated. elasticsearch-server.version version that we have in POM (7.16.3) and is used for testing doesn't match the default we have in the config for dev services (7.17.0) and the ES client is 8.8.2 (while 7.10.2 for proprietary components, which is expected). As for OpenSearch, opensearch-server.version is 1.2.3 while there's already a 2.8.0. At least, I'd expect that the version we are testing against and the version of dev services would match...

[quarkus-bot]

/cc @gsmet (elasticsearch,hibernate-search), @loicmathieu (elasticsearch), @yrodiere (elasticsearch,hibernate-search)

[gsmet]

Spotted a few minor things, otherwise that's great (but I will probably let Yoann have a look when he's back).

As for versions being a bit weird, it all boils down to us still supporting the old Elasticsearch high level client, but we should fix this soon hopefully: see #31997 .

[marko-bekhta]

Thanks for taking a look and for the link! 😃 I've addressed your suggestions, but will keep them locally for now, to not trigger more builds for now 😃

let Yoann have a look when he's back

yeah, I've also noticed the comments that we can only start the default backend, but couldn't think of anything obvious that would limit us from starting multiple instances, so wanted to check with Yoann on that too once he's back 😃

[yrodiere]

yeah, I've also noticed the comments that we can only start the default backend, but couldn't think of anything obvious that would limit us from starting multiple instances, so wanted to check with Yoann on that too once he's back smiley

See #24011, which has a few links that might explain the history of this limitation. I don't know from the top of my head why it's there. Maybe it was just the minimum viable product, and we never went beyond that.

[yrodiere]

Thanks. I agree with Guillaume's comments, and added some of my own below.

[github-actions]

🙈 The PR is closed and the preview is expired.

[yrodiere]

Thanks! The automatic resolution of Elasticsearch/OpenSearch will be a great addition.
A few comments on the implementation below.

[yrodiere]

LGTM, thanks!

Comments were addressed

[yrodiere]

Ok that's a new one:

2023-08-14T17:15:52.0868161Z [ERROR] Tests run: 10, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 10.34 s <<< FAILURE! -- in io.quarkus.hibernate.orm.multiplepersistenceunits.MultiplePersistenceUnitsCdiEntityManagerTest
2023-08-14T17:15:52.0875976Z [ERROR] io.quarkus.hibernate.orm.multiplepersistenceunits.MultiplePersistenceUnitsCdiEntityManagerTest.usersEntityManagerInRequestNoTransaction -- Time elapsed: 6.022 s <<< FAILURE!
2023-08-14T17:15:52.0876971Z java.lang.AssertionError:
2023-08-14T17:15:52.0877941Z
2023-08-14T17:15:52.0878281Z Expecting code not to raise a throwable but caught
2023-08-14T17:15:52.0878708Z "java.lang.OutOfMemoryError: Metaspace

I'll don't see how that would be caused by this PR though... I'll ask around.

[gsmet]

I rebased to get at least one JVM build green.

[quarkus-bot]

Failing Jobs - Building cd90a56

Status	Name	Step	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 11
✔️	JVM Tests - JDK 17
✖	JVM Tests - JDK 17 Windows	Build	⚠️ Check →	Logs	Raw logs
✖	JVM Tests - JDK 20	Build	⚠️ Check →	Logs	Raw logs