-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: spring annotations project creation. #3492
feat: spring annotations project creation. #3492
Conversation
@geoand correct me if I am wrong, I see two potential problems:
|
I won't really be able to review for a few days, so up to you really to request changes if you think they are necessary 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gsmet, what's your opinion? I am not totally sure, but I think it would make more sense to have this feature part of the AddExtensions
mechanism. It would create the Spring file, even when adding the spring extension in an existing project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, I added a few comments inline.
devtools/common/src/main/resources/templates/basic-rest/java/test-resource-template.ftl
Outdated
Show resolved
Hide resolved
devtools/common/src/main/resources/templates/basic-rest/java/spring-resource-template.ftl
Outdated
Show resolved
Hide resolved
devtools/common/src/main/resources/templates/basic-rest/java/resource-template.ftl
Outdated
Show resolved
Hide resolved
devtools/common/src/main/java/io/quarkus/cli/commands/CreateProject.java
Show resolved
Hide resolved
devtools/common/src/test/java/io/quarkus/cli/commands/CreateProjectTest.java
Outdated
Show resolved
Hide resolved
devtools/common/src/test/java/io/quarkus/cli/commands/CreateProjectTest.java
Outdated
Show resolved
Hide resolved
@ia3andy I don't know. I'm not very excited at the idea of creating new files when adding an extension to an existing project. |
@gsmet I don't know either, but having different behavior (before and after) is as troubling to me.. maybe this should not be treated automatically with the extension but more as an option in the create command? |
I don't think it's an issue. For me it's two different things:
I don't think it's an issue. |
@gsmet ok, so I guess this PR includes two features:
The order of call seems to still be an issue, I'll update my "Change Request".. |
devtools/common/src/main/java/io/quarkus/cli/commands/CreateProject.java
Show resolved
Hide resolved
@aureamunoz you will also have to rebase onto the latest master since there are some conflicts |
@aureamunoz in your implementation, the |
6bba81a
to
1c58752
Compare
devtools/common/src/main/java/io/quarkus/generators/SourceType.java
Outdated
Show resolved
Hide resolved
devtools/common/src/test/java/io/quarkus/cli/commands/CreateProjectTest.java
Outdated
Show resolved
Hide resolved
Related to issue quarkusio#3437
1c58752
to
798c10e
Compare
@geoand feel free to do it, I trust your judgement on this one. |
Thanks! |
Tested locally and things work as expected. Thanks for the PR! |
Related to issue #3437