Allow adding more claims to OIDC JWT authentication token #34883
Conversation
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
|
This looks really good. Much appreciated |
| @@ -367,6 +368,11 @@ public static String signJwtWithKey(OidcCommonConfig oidcConfig, String tokenReq | |||
| } | |||
| } | |||
|
|
|||
| @SuppressWarnings({ "unchecked", "rawtypes" }) | |||
There was a problem hiding this comment.
This method is only introduced so you don't have to annotate signJwtWithKey with SuppressWarnings, right?
There was a problem hiding this comment.
@lordvlad Yes, it is guaranteed Quarkus Config will init an empty or non empty Map with string value. When dealing directly with the JWT build api, Map can contains complex claims like arrays or objects
|
Thanks @lordvlad for your original PR and the discussion which has led us to introducing a map, users should now be able to add whatever simple custom string claims they need. Support for complex claims, non String types can be reviewed as needed |
|
@sberyozkin quick question, to understand the release process: why was this not included in 3.2.2.Final? Cause the scope for 3.2.2 was already set? Will it be included in 3.2.3? |
|
It will be included in 3.3.0.CR1, due in August 9th, see https://github.com/quarkusio/quarkus/wiki/Release-Planning |
|
@lordvlad Sometimes we can request backports for bug fixes - but this one can be considered a new feature, which is why it is planned for 3.3.0.CR1, I hope you'll have no problems migrating |
|
👍
…On Fri, Jul 28, 2023, 00:35 Sergey Beryozkin ***@***.***> wrote:
@lordvlad <https://github.com/lordvlad> Sometimes we can request
backports for bug fixes - but this one can be considered a new feature,
which is why it is planned for 3.3.0.CR1, I hope you'll have no problems
migrating
—
Reply to this email directly, view it on GitHub
<#34883 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJJJ2IFHM2FILTABVFIWTDXSLULZANCNFSM6AAAAAA2RGXF7E>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Replaces #34686.
@lordvlad, can you please check this PR ?
I thought first I'd start cherry-picking from your PR but then decided not to since having a Map as we agreed in #34686 makes code changes different. I thought it would be simpler to recreate a PR due to the merge issues in your original PR