Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the creation of the Tracer bean lazy #34879

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Make the creation of the Tracer bean lazy #34879

merged 1 commit into from
Jul 20, 2023

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jul 20, 2023 •
edited
Loading

This is needed to avoid a timing issue
that can lead to java.lang.IllegalStateException: GlobalOpenTelemetry.set has already been called

In rare cases this could happen in our tests that do have an @Inject Tracer tracer injection point

@geoand
Make the creation of the Tracer bean lazy
147601c 
This is needed to avoid a timing issue
that can lead to
java.lang.IllegalStateException: GlobalOpenTelemetry.set has already been called
@geoand geoand requested a review from brunobat July 20, 2023 09:18
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 20, 2023

/cc @brunobat (opentelemetry), @radcortez (opentelemetry)

brunobat
brunobat approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@brunobat brunobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoand
Copy link
Contributor Author

geoand commented Jul 20, 2023

🙏🏼

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 20, 2023

Failing Jobs - Building 147601c

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
✖ JVM Tests - JDK 17 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 19

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 Windows #

- Failing: integration-tests/rest-client

📦 integration-tests/rest-client

✖ io.quarkus.it.rest.client.wronghost.ExternalWrongHostUsingHostnameVerifierTestCase.restClient - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/sun.nio.ch.NioSocketImpl.timedRead(NioSocketImpl.java:283)
	at java.base/sun.nio.ch.NioSocketImpl.implRead(NioSocketImpl.java:309)

@geoand geoand merged commit 3e04a2c into quarkusio:main Jul 20, 2023
@quarkus-bot quarkus-bot bot added this to the 3.3 - main milestone Jul 20, 2023
@geoand geoand deleted the tracer-lazy branch July 20, 2023 10:26
@geoand geoand mentioned this pull request Jul 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunobat brunobat brunobat approved these changes

Assignees
No one assigned
Labels
area/tracing
Projects
None yet
Milestone
3.3.0.CR1
Development

Successfully merging this pull request may close these issues.
2 participants
@geoand @brunobat