Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix case where both http and https ports set to 0 in tests #34849

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jul 19, 2023

No description provided.

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 19, 2023
@jsight
Copy link

jsight commented Jul 19, 2023

I have validated that this passes for my test application!

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 19, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gastaldi gastaldi merged commit 9192e79 into quarkusio:main Jul 19, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 19, 2023
@gastaldi gastaldi deleted the #34799 branch July 19, 2023 18:00
@quarkus-bot quarkus-bot bot added this to the 3.3 - main milestone Jul 19, 2023
@gsmet
Copy link
Member

gsmet commented Jul 20, 2023

There is a conflict with this backport so if you want it backported, please prepare a specific PR for 3.2.

@geoand
Copy link
Contributor Author

geoand commented Jul 20, 2023

No problem, thanks for the heads up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PortSystemProperties does not set test-ssl-port which causes issues in rest-assured when ports are 0
4 participants