Allow Type Reference in the Redis data source #34841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
machi1990
reviewed
Jul 19, 2023
machi1990
reviewed
Jul 19, 2023
gsmet
reviewed
Jul 19, 2023
machi1990
approved these changes
Jul 19, 2023
The Redis data source used Class<?> to configure the type safety. Unfortunately, it didn't work with generics. This commit adds methods using (Jackson) TypeReference to configure the various groups. Thus, generics are now supported. Also: - deprecate the graph group, as Redis declared it is as end-of-life ( :-( ) - deprecate search(Class<K> keyType) as the index must be a string - re-structure a bit the Redis reference guide
cescoffier
force-pushed
the
redis-use-type-reference
branch
from
879a286 to
ed8b789
Compare
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows configuring the Redis data source with type references
The Redis data source used Class<?> to configure the type safety. Unfortunately, it didn't work with generics.
This commit adds methods using (Jackson) TypeReference to configure the various groups. Thus, generics are now supported.
Also:
Fix #34554
Fix #29865