Add diagram of Quarkus ClassLoader hierarchy #34818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holly-cummins
force-pushed
the
classloader-diagram
branch
from
f1d77c0 to
977fe1c
Compare
holly-cummins
force-pushed
the
classloader-diagram
branch
from
977fe1c to
5444472
Compare
|
🙈 The PR is closed and the preview is expired. |
|
https://quarkus-pr-main-34818-preview.surge.sh/version/main/guides/class-loading-reference is the exact page in the preview that's changed. Annoyingly, https://quarkus-pr-main-34818-preview.surge.sh/version/main/guides/images/classloader-hierarchy.svg renders fine, but when it's inline in the guide it's blank, at least on the preview. So I think I'll give up on svg and switch to png. |
gsmet
approved these changes
Jul 21, 2023
geoand
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to draw myself a diagram when reading https://quarkus.io/guides/class-loading-reference. Sharing the diagram, since I think it will help others follow the text.
There’s nothing worse than an image that can’t be edited, so I’ve checked the .key file in as well. I know that not everyone can actually use .key files, so a .key file is semi-worse. :) I looked into redoing the file in Excalidraw or PlantUML, but we would lose control of the fonts. I decided the finished image was more important than maximum inclusiveness on the raw file.
I converted from .key to .svg using https://image.online-convert.com/convert/key-to-svg.
@geoand points out we usually call it "Augmentation ClassLoader," not "Augment ClassLoader." I've confirmed that with a search of our code comments, so updated the guide text with the more usual name.