Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve OIDC multi-tenancy and providers docs #34659

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Improve OIDC multi-tenancy and providers docs #34659

merged 1 commit into from
Jul 11, 2023

Conversation

sberyozkin
Copy link
Member

This PR tries to improve, add more information that can be practically useful to OIDC multi-tenancy and provider docs.

  • Better description of various options for resolving tenant identifiers in the OIDC multitenancy , with the default resolution section being a totally new content
  • Added a section to the well known providers doc clarifying what it takes to support more than one provider
  • Added a section to the well known providers doc clarifying how a typical task of accessing some provider services after the authentication has been successfully completed can be easily achieved in Quarkus

@sberyozkin sberyozkin force-pushed the well_known_providers_doc_updates branch from 896445a to 3c116e0 Compare July 10, 2023 18:23
@github-actions
Copy link

github-actions bot commented Jul 10, 2023 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@sberyozkin
Copy link
Member Author

Thanks @gastaldi, will handle tomorrow

@sberyozkin sberyozkin mentioned this pull request Jul 11, 2023
Closed
@sberyozkin sberyozkin marked this pull request as draft July 11, 2023 09:59
@sberyozkin
Copy link
Member Author

Thanks @gastaldi and @michelle-purcell, Michelle, I think I may be starting learning something, finally :-)

@sberyozkin sberyozkin force-pushed the well_known_providers_doc_updates branch from 14bf6a2 to 7f09d76 Compare July 11, 2023 10:17
@sberyozkin sberyozkin force-pushed the well_known_providers_doc_updates branch from 7f09d76 to 946bfe6 Compare July 11, 2023 10:20
@sberyozkin sberyozkin marked this pull request as ready for review July 11, 2023 10:20
@sberyozkin
Copy link
Member Author

@michelle-purcell Thanks again, applied all your suggestions

michelle-purcell
michelle-purcell approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@michelle-purcell michelle-purcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sberyozkin - Great job 🎉 See my comments above.

I noticed some grammar issues in some content that is untouched by this PR but I ignored them (for now...) as the scope of this review is mainly the changed content. Hope that's OK. Thanks.

docs/src/main/asciidoc/security-openid-connect-multitenancy.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/security-openid-connect-providers.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/security-openid-connect-providers.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/security-openid-connect-providers.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/security-openid-connect-providers.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/security-openid-connect-providers.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/security-openid-connect-providers.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/security-openid-connect-providers.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/security-openid-connect-providers.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/security-openid-connect-providers.adoc Outdated Show resolved Hide resolved
@sberyozkin
Copy link
Member Author

Hey @michelle-purcell Sure :-). thanks for more suggestions, let me apply them

@sberyozkin sberyozkin force-pushed the well_known_providers_doc_updates branch from bcddf3e to e381873 Compare July 11, 2023 11:28
@sberyozkin sberyozkin merged commit 80826ec into quarkusio:main Jul 11, 2023
@quarkus-bot quarkus-bot bot added this to the 3.3 - main milestone Jul 11, 2023
@sberyozkin sberyozkin deleted the well_known_providers_doc_updates branch July 11, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelle-purcell michelle-purcell michelle-purcell approved these changes

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
area/documentation
Projects
None yet
Milestone
3.3.0.CR1
Development

Successfully merging this pull request may close these issues.
3 participants
@sberyozkin @gastaldi @michelle-purcell