-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for absolute paths for jacoco exec and report #34544
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,10 +11,11 @@ | |
public class JacocoConfig { | ||
|
||
/** | ||
* The jacoco data file | ||
* The jacoco data file. By default this will be target/jacoco-quarkus.exec. | ||
* The path can be relative (to the module) or absolute. | ||
*/ | ||
@ConfigItem(defaultValue = "jacoco-quarkus.exec") | ||
public String dataFile; | ||
@ConfigItem | ||
public Optional<String> dataFile; | ||
Comment on lines
+17
to
+18
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's the rationale of this change? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I changed the default to be the equivalent of There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Makes sense, thanks. What I would like however is some Javadoc explaining this process so users who might want to configure it can find this information on our config page (or their IDE if it supports it) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. sure thing, which I did I believe:
do you think this should be more detailed? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I guess it's fine. |
||
|
||
/** | ||
* Whether to reuse ({@code true}) or delete ({@code false}) the jacoco | ||
|
@@ -82,8 +83,9 @@ public class JacocoConfig { | |
public Optional<List<String>> excludes; | ||
|
||
/** | ||
* The location of the report files. | ||
* The location of the report files. By default this will be target/jacoco-report. | ||
* The path can be relative (to the module) or absolute. | ||
*/ | ||
@ConfigItem(defaultValue = "jacoco-report") | ||
public String reportLocation; | ||
@ConfigItem | ||
public Optional<String> reportLocation; | ||
Comment on lines
+89
to
+90
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same reason as for data file |
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use
defaultValueForDocumentation
instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't remember that at all. @vsevel fancy doing a new PR with this improvement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. I will add some info on the guide as well