Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove long deprecated options from CertificateConfig #34540

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jul 5, 2023

These options where deprecated more than 2 years ago in 272119d

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe let's try to get #33228 in before doing that.

I'll rebase and try to get it merged soon.

@geoand
Copy link
Contributor Author

geoand commented Jul 5, 2023

Sure, no problem

@quarkus-bot

This comment has been minimized.

@gsmet gsmet force-pushed the certificate-config-deprecated branch from 4f48afc to d55e533 Compare August 2, 2023 16:12
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased this PR and fixed the gRPC tests.

@geoand
Copy link
Contributor Author

geoand commented Aug 2, 2023

💪

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 2, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@geoand geoand merged commit 97330b9 into quarkusio:main Aug 3, 2023
@quarkus-bot quarkus-bot bot added this to the 3.3 - main milestone Aug 3, 2023
@geoand geoand deleted the certificate-config-deprecated branch August 3, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants