Implement Redis custom codec support #34486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machi1990
reviewed
Jul 3, 2023
| import static io.quarkus.redis.client.deployment.RedisClientProcessor.REDIS_CLIENT_ANNOTATION; | ||
| import static io.quarkus.redis.client.deployment.RedisClientProcessor.configureAndCreateSyntheticBean; | ||
| import static io.quarkus.redis.client.deployment.RedisClientProcessor.configuredClientNames; | ||
| import static io.quarkus.redis.client.deployment.RedisClientProcessor.*; |
machi1990
reviewed
Jul 3, 2023
There was a problem hiding this comment.
lgtm, thanks @cescoffier
I've left one nit suggestion, should be good to merge once that is addressed and the test passes.
cescoffier
force-pushed
the
redis-custom-codec
branch
from
cbdded4 to
6e7d4a1
Compare
|
🙈 The PR is closed and the preview is expired. |
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
machi1990
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #34329