Revert "Work around https://hibernate.atlassian.net/browse/HHH-16832" #34465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
@yrodiere CI seems unhappy about it.. could you double-check the effectiveness of the fix? |
|
Sorry, can't do right now, too many urgent things to do. I'll get back to it when possible. |
|
So the fix worked only partially, we still need to fix https://hibernate.atlassian.net/browse/HHH-17034 |
|
Let's rebase this after #35690 |
yrodiere
force-pushed
the
revert-HHH-16832-workaround
branch
from
7df2c5f to
edb8fbb
Compare
Done, let's see. |
This comment has been minimized.
This comment has been minimized.
|
It works now, but I'll need some approval before I can merge :) @Sanne? |
Sanne
force-pushed
the
revert-HHH-16832-workaround
branch
from
edb8fbb to
a3ca174
Compare
Sanne
approved these changes
Sep 20, 2023
gastaldi
added
triage/waiting-for-ci
This reverts commit 823591f.
gsmet
force-pushed
the
revert-HHH-16832-workaround
branch
from
a3ca174 to
a74d53b
Compare
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 823591f.
As suggested here after the upgrade to Hibernate ORM 6.2.6.Final.