Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent implicit image push when image build is explicitly disabled #34431

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Prevent implicit image push when image build is explicitly disabled #34431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...e/deployment/src/main/java/io/quarkus/container/image/deployment/util/EnablementUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ public static boolean buildContainerImageNeeded(ContainerImageConfig containerIm
public static boolean pushContainerImageNeeded(ContainerImageConfig containerImageConfig,
Optional<ContainerImagePushRequestBuildItem> pushRequest) {
return containerImageConfig.isPushExplicitlyEnabled()
|| (pushRequest.isPresent() && !containerImageConfig.isPushExplicitlyDisabled());
// Never push an image when build is disabled (it may not even exist).
|| (pushRequest.isPresent() && !containerImageConfig.isBuildExplicitlyDisabled()
&& !containerImageConfig.isPushExplicitlyDisabled());
}

public static boolean buildOrPushContainerImageNeeded(ContainerImageConfig containerImageConfig,
Expand Down