Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qute: ValueResolverGenerator optimization - reduce allocations #34420

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Qute: ValueResolverGenerator optimization - reduce allocations #34420

merged 1 commit into from
Jun 30, 2023

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jun 29, 2023

  • use shared constants for booleans, enums and nulls

@quarkus-bot quarkus-bot bot added the area/qute The template engine label Jun 29, 2023
@mkouba mkouba force-pushed the qute-generators-alloc-optim branch from b6d7e59 to a857c4f Compare June 29, 2023 15:46
@mkouba mkouba marked this pull request as ready for review June 29, 2023 18:04
@mkouba mkouba requested a review from gastaldi June 29, 2023 18:04
@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
@mkouba
Qute: ValueResolverGenerator optimization - reduce allocations
4fd19eb 
- use shared constants for booleans, enums and nulls
@mkouba mkouba force-pushed the qute-generators-alloc-optim branch from a857c4f to 4fd19eb Compare June 30, 2023 06:36
@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 30, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 30, 2023

Failing Jobs - Building 4fd19eb

Status Name Step Failures Logs Raw logs
⌛ JVM Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 17
✔️ JVM Tests - JDK 19

@mkouba mkouba merged commit 2cf035a into quarkusio:main Jun 30, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 30, 2023
@quarkus-bot quarkus-bot bot added this to the 3.3 - main milestone Jun 30, 2023
@imperatorx imperatorx mentioned this pull request Aug 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
area/qute The template engine
Projects
None yet
Milestone
3.3.0.CR1
Development

Successfully merging this pull request may close these issues.
2 participants
@mkouba @gastaldi