ArC: add support for custom AlterableContext implementations #34418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
mkouba
reviewed
Jun 30, 2023
...t-projects/arc/processor/src/main/java/io/quarkus/arc/processor/CustomAlterableContexts.java
Show resolved
Hide resolved
mkouba
reviewed
Jun 30, 2023
...ects/arc/tests/src/test/java/io/quarkus/arc/test/cdi/bcextensions/CustomNormalScopeTest.java
Show resolved
Hide resolved
mkouba
reviewed
Jun 30, 2023
...ects/arc/tests/src/test/java/io/quarkus/arc/test/cdi/bcextensions/CustomPseudoScopeTest.java
Outdated
Show resolved
Hide resolved
Ladicek
force-pushed
the
arc-custom-alterable-contexts
branch
from
25b1a5f to
4c5fcf5
Compare
mkouba
approved these changes
Jun 30, 2023
This comment has been minimized.
This comment has been minimized.
manovotn
approved these changes
Jul 4, 2023
This comment has been minimized.
This comment has been minimized.
|
I'll rebase to rerun CI. |
Custom contexts in ArC must implement the `InjectableContext` interface, which is ArC-specific. To implement CDI Lite properly, ArC must also support custom implementations of `AlterableContext`. Fortunately, the `InjectableContext` interface adds just a few methods on top of `AlterableContext`, and none of them are critical for custom contexts to function. Therefore, with this commit, we simply take the user-supplied implementation of `AlterableContext` and generate a subclass that implements `InjectableContext`, where all the additional methods throw `UnsupportedOperationException`. This subclass is then registered as the custom context, instead of the original user-supplied class.
Ladicek
force-pushed
the
arc-custom-alterable-contexts
branch
from
4c5fcf5 to
8123224
Compare
mkouba
added
the
triage/waiting-for-ci
This comment has been minimized.
This comment has been minimized.
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
quarkus-bot
bot
added
kind/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom contexts in ArC must implement the
InjectableContextinterface, which is ArC-specific. To implement CDI Lite properly, ArC must also support custom implementations ofAlterableContext.Fortunately, the
InjectableContextinterface adds just a few methods on top ofAlterableContext, and none of them are critical for custom contexts to function. Therefore, with this commit, we simply take the user-supplied implementation ofAlterableContextand generate a subclass that implementsInjectableContext, where all the additional methods throwUnsupportedOperationException. This subclass is then registered as the custom context, instead of the original user-supplied class.Resolves #33664