2.16.8 backports 1 #34384
Merged
2.16.8 backports 1 #34384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both custom HostnameVerifier and SSLContext are currently not supported by resteasy-reactive-client. This is documented as known limitations. This change aligns the implementation to the already present state for SSLContext. It makes the builder fail when HostnameVerifier is tried to be configured. The benefit is that it fails as early as currently possible and not only when the custom hostname verification would be needed later on. Switch both to UnsupportedOperationException. On the rest-client-reactive settings a custom hostname verifier is currently not supported. Adapted the tests accordingly as the builder fails early now throwing UnsupportedOperationException. (cherry picked from commit 6ce558f)
quarkus-bot
bot
added
area/config
area/core
area/dependencies
This comment has been minimized.
This comment has been minimized.
Since introduction of the setting 'verifyHost' the hostname verification was disabled by default for the resteasy-reactive-client, as the default value for boolean (primitive) is false. This disabled default makes the reactive client vulnerable to MITM attacks. In the meantime setting the config explicitly is a workaround e.g. with 'quarkus.rest-client.verify-host=true'. This change now adds a proper default both in the configuration and for the field in the reactive client builder implementation. Add test case for enabled host verification default (cherry picked from commit 18f6f4c)
(cherry picked from commit d4dc940)
Fixed typo in mention of default value for token name; fixed missing parameter type and import in code example (cherry picked from commit 37f7f5b)
When providing a location, the URI was being decoded, so the value was being altered from what users set. Note that these changes are based on what Resteasy already does: https://github.com/resteasy/resteasy/blob/dadddfb699a875c44ba05c0abe176873acbd9aa2/resteasy-core/src/main/java/org/jboss/resteasy/specimpl/ResponseBuilderImpl.java#L187 Fix quarkusio#33419 (cherry picked from commit ced8b0a)
Fixes: quarkusio#33490 (cherry picked from commit 196b742)
(cherry picked from commit 0e9a248)
(cherry picked from commit 28034bb)
(cherry picked from commit e2cb17c)
This has been done a long while ago for standard apps but I missed to update the CLI somehow. (cherry picked from commit f246839)
(cherry picked from commit 15b2ece)
gsmet
force-pushed
the
2.16.8-backports-1
branch
from
c796a06 to
a4aabec
Compare
|
🎊 PR Preview fbbbc31 has been successfully built and deployed to https://quarkus-pr-main-34384-preview.surge.sh/version/main/guides/ |
Failing Jobs - Building a4aabec
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 Windows #- Failing: extensions/grpc/deployment
! Skipped: extensions/micrometer-registry-prometheus/deployment extensions/micrometer/deployment extensions/opentelemetry/deployment and 39 more📦 extensions/grpc/deployment✖ ⚙️ Native Tests - Windows - RESTEasy Jackson #- Failing: integration-tests/resteasy-jackson
📦 integration-tests/resteasy-jackson✖ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please don't merge, I will merge it myself.