Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reactive Messaging Pulsar Extension #34378

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Reactive Messaging Pulsar Extension #34378

merged 1 commit into from
Jul 3, 2023

Conversation

ozangunalp
Copy link
Contributor

@ozangunalp ozangunalp commented Jun 28, 2023 •
edited
Loading

Bumps Smallrye Reactive Messaging to 4.7.0

Adds smallrye-reactive-messaging-pulsar extension
Adds docs for

Known issues
Native compilation with GraalVM 23 has a runtime issue in schema serialization of schema type PROTOBUF_NATIVE.

@ozangunalp ozangunalp requested review from cescoffier and geoand June 28, 2023 13:01
@ozangunalp ozangunalp mentioned this pull request Jun 28, 2023
Merged
10 tasks
@quarkus-bot quarkus-bot bot added area/core area/dependencies Pull requests that update a dependency file area/documentation area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/reactive-messaging area/smallrye labels Jun 28, 2023
@quarkus-bot

This comment has been minimized.

Sign in to view
cescoffier
cescoffier requested changes Jun 28, 2023
View reviewed changes
Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if we should add a test verifying the KeyedMulti receiving messages. WDYT?

.github/native-tests.json Show resolved Hide resolved
...llrye-reactive-messaging-pulsar/deployment/src/test/resources/application-secured.properties Outdated Show resolved Hide resolved
...ions/smallrye-reactive-messaging-pulsar/deployment/src/test/resources/application.properties
@@ -0,0 +1,4 @@
mp.messaging.outgoing.source.connector=smallrye-pulsar

mp.messaging.incoming.in.connector=smallrye-pulsar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated to that PR - I'm started to think we should drop smallrye-. It can be confusing. (both value should work)

integration-tests/reactive-messaging-pulsar/src/main/resources/test_ecdsa_privkey.pem Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jun 28, 2023 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@ozangunalp ozangunalp force-pushed the pulsar_extension_3.0.0 branch from 8b13146 to fa06fca Compare June 28, 2023 17:00
@quarkus-bot quarkus-bot bot added the area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins label Jun 28, 2023
@quarkus-bot

This comment has been minimized.

Sign in to view
@ozangunalp ozangunalp force-pushed the pulsar_extension_3.0.0 branch from fa06fca to f9a6cc1 Compare June 29, 2023 05:10
geoand
geoand reviewed Jun 29, 2023
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see it!

@ozangunalp ozangunalp force-pushed the pulsar_extension_3.0.0 branch from f9a6cc1 to 63d1dc2 Compare June 29, 2023 07:09
@geoand geoand removed area/documentation area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure labels Jun 29, 2023
@quarkus-bot

This comment has been minimized.

Sign in to view
@geoand
Copy link
Contributor

geoand commented Jun 29, 2023

The CI failure seems related

@cescoffier
Copy link
Member

Yep:-(

@ozangunalp
Copy link
Contributor Author

I'll take a look tonight. It must be a misconfiguration on my part, IIRC we don't have container runtime on windows tests, @geoand right?

@geoand
Copy link
Contributor

geoand commented Jun 29, 2023

Correct

@ozangunalp ozangunalp force-pushed the pulsar_extension_3.0.0 branch from 63d1dc2 to 8dc4f9d Compare June 29, 2023 19:33
@quarkus-bot quarkus-bot bot added area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure labels Jun 29, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 30, 2023

Failing Jobs - Building 8dc4f9d

Status Name Step Failures Logs Raw logs
⌛ Native Tests - Security1 Build ⚠️ Check → Logs Raw logs

@ozangunalp
Copy link
Contributor Author

The timeout doesn't seem related.

@geoand
Copy link
Contributor

geoand commented Jun 30, 2023

Agreed

@cescoffier cescoffier merged commit 5d31f63 into quarkusio:main Jul 3, 2023
@quarkus-bot quarkus-bot bot added this to the 3.3 - main milestone Jul 3, 2023
@cescoffier
Copy link
Member

Woohoo!

@cescoffier cescoffier mentioned this pull request Jul 3, 2023
Closed
@ozangunalp ozangunalp deleted the pulsar_extension_3.0.0 branch July 3, 2023 19:51
@humcqc humcqc mentioned this pull request May 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand left review comments

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/reactive-messaging area/smallrye release/noteworthy-feature
Projects
None yet
Milestone
3.3.0.CR1
Development

Successfully merging this pull request may close these issues.
3 participants
@ozangunalp @geoand @cescoffier