Dev UI: Add favourite functionallity for extension cards #34323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cescoffier
approved these changes
Jun 27, 2023
phillip-kruger
added
the
triage/waiting-for-ci
This comment has been minimized.
This comment has been minimized.
gsmet
requested changes
Jun 27, 2023
extensions/vertx-http/dev-ui-resources/src/main/resources/dev-ui/qwc/qwc-extensions.js
Outdated
Show resolved
Hide resolved
extensions/vertx-http/dev-ui-resources/src/main/resources/dev-ui/qwc/qwc-extensions.js
Outdated
Show resolved
Hide resolved
phillip-kruger
force-pushed
the
dev-ui-favs
branch
from
5fd452b to
6360522
Compare
Signed-off-by: Phillip Kruger <[email protected]>
phillip-kruger
force-pushed
the
dev-ui-favs
branch
from
6360522 to
510d486
Compare
melloware
approved these changes
Jun 27, 2023
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
|
@gsmet can we merge the current version? We can always enhance it later if we see that is what users want... |
|
Let's wait for feedback before storing the favorites by apps. I see the use case, but it may be specific to the kind of work we are doing (where the application we do in the morning is very different from the one we do in the afternoon). |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you tired of searching for your favourite extension card in Dev UI ? This PR introduce the ability to favour a card, that will show it first.