Fix AMQP Dev Services started message #34318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
gsmet
requested changes
Jun 27, 2023
Comment on lines
+135
to
+139
| log.infof("Dev Services for AMQP started. Other Quarkus applications in dev mode will find the " | ||
| + "broker automatically. For Quarkus applications in production mode, you can connect to" | ||
| + " this by starting your application with -Damqp.host=%s -Damqp.port=%s -Damqp.user=%s -Damqp.password=%s", | ||
| config.get(AMQP_HOST_PROP), config.get(AMQP_PORT_PROP), config.get(AMQP_USER_PROP), | ||
| config.get(AMQP_PASSWORD_PROP)); |
There was a problem hiding this comment.
I would prefer if we kept the message separate to be more consistent with the logging we do in other dev services (i.e. one line with the started message).
There was a problem hiding this comment.
not everywhere - https://github.com/quarkusio/quarkus/blob/main/extensions/kafka-client/deployment/src/main/java/io/quarkus/kafka/client/deployment/DevServicesKafkaProcessor.java#L129. I still think that having it in two messages is not connected at first sight. At least, it's not totally clear to me. But I'll change it back if you request.
gsmet
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This message was not printed since the compressor was still active. Also merge the messages since the second message doesn't make sense without first one.