Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #312, make JAX-RS resources @Singleton by default #343

Merged
merged 1 commit into from
Dec 19, 2018

Conversation

stuartwdouglas
Copy link
Member

Also fixes and issue where @context injection does not work for normal scoped JAX-RS endpoints

Also fixes and issue where @context injection does not work for normal scoped JAX-RS endpoints
@mkouba
Copy link
Contributor

mkouba commented Dec 19, 2018

Looks good except it wouldn't work if a user annotates a jax-rs resource with a stereotype which has a different default scope - this would result in IllegalStateException. However, this should rarely happen. I would just add an impl. note to JaxrsScanningProcessor#singletonResources javadoc.

@mkouba mkouba merged commit 52b0001 into quarkusio:master Dec 19, 2018
@gsmet gsmet added this to the 0.3.0 milestone Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants