Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail when using collections in Resteasy Reactive JAXB #34237

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Fail when using collections in Resteasy Reactive JAXB #34237

merged 1 commit into from
Jun 23, 2023

Conversation

Sgitario
Copy link
Contributor

Fix #33865

More details in #33865 (comment).

@geoand we could also validate also the inputs, so I'm not sure if we should do this, wdyt?

@Sgitario Sgitario requested a review from geoand June 22, 2023 07:39
@geoand
Copy link
Contributor

geoand commented Jun 22, 2023

With regards to the question about the input: what happens currently? Does it fail at runtime in a similar way as it does for the output?

@Sgitario
Copy link
Contributor Author

With regards to the question about the input: what happens currently? Does it fail at runtime in a similar way as it does for the output?

org.glassfish.jaxb.runtime.v2.runtime.IllegalAnnotationsException: 1 counts of IllegalAnnotationExceptions
java.util.List es una interfaz y JAXB no puede manejar interfaces.
	this problem is related to the following location:
		at java.util.List

So, yes, we should also validate the params.

@Sgitario Sgitario changed the title Fail when returning collections in Resteasy Reactive JAXB Fail when using collections in Resteasy Reactive JAXB Jun 22, 2023
@Sgitario
Copy link
Contributor Author

@geoand PR updated

@quarkus-bot

This comment has been minimized.

Sign in to view
@Sgitario Sgitario requested a review from geoand June 22, 2023 11:38
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 22, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@Sgitario Sgitario merged commit 6c169af into quarkusio:main Jun 23, 2023
@Sgitario Sgitario deleted the 33865 branch June 23, 2023 04:48
@quarkus-bot quarkus-bot bot added this to the 3.3 - main milestone Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/rest kind/bugfix release/breaking-change
Projects
None yet
Milestone
3.3.0.CR1
Development

Successfully merging this pull request may close these issues.

RestEasy Reactive + JAXB unable to serialize list of entities
2 participants
@Sgitario @geoand