-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable build scan publication for test builds #34158
Disable build scan publication for test builds #34158
Conversation
2dc3508
to
50a1f35
Compare
This comment has been minimized.
This comment has been minimized.
@@ -91,6 +91,7 @@ | |||
<version>${maven-invoker-plugin.version}</version> | |||
<!-- https://maven.apache.org/plugins/maven-invoker-plugin/usage.html --> | |||
<configuration> | |||
<mavenOpts>-Dscan=false</mavenOpts> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why set it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some smoke tests are triggering some Maven builds which would publish some build scans.
not great we have to change the code this much (its not a lot but also more than nothing ;) but if no other way to avoid the scan to be submitted I guess we have to go for this approach. I would have preferred a way to detect it in the groovy rules. but +1 on this if no better alternative |
This is the best we have so far if we want to make sure no test builds are published |
Let's pause this for a second, there might be a simpler option using the Groovy script I convert this PR to draft and propose a new version ASAP |
Closing in favor of #34335 |
Issue
The Quarkus build is comprised of many test builds which by default publish some build scans to Gradle Enterprise.
The current approach only publish those test builds when failing. This is however not sufficient as some tests are expecting builds to fail.
Fix
As described here, use the -Dscan=false system property where required