Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable build scan publication for test builds #34158

Closed

Conversation

jprinet
Copy link
Contributor

@jprinet jprinet commented Jun 20, 2023

Issue

The Quarkus build is comprised of many test builds which by default publish some build scans to Gradle Enterprise.
The current approach only publish those test builds when failing. This is however not sufficient as some tests are expecting builds to fail.

Fix

As described here, use the -Dscan=false system property where required

@quarkus-bot quarkus-bot bot added area/cli Related to quarkus cli (not maven/gradle/etc.) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/jbang Issues related to when using jbang.dev with Quarkus area/kotlin area/kubernetes area/maven area/scala area/testing labels Jun 20, 2023
@jprinet jprinet force-pushed the fix/do-not-publish-test-build-scans branch from 2dc3508 to 50a1f35 Compare June 20, 2023 16:38
@quarkus-bot

This comment has been minimized.

@@ -91,6 +91,7 @@
<version>${maven-invoker-plugin.version}</version>
<!-- https://maven.apache.org/plugins/maven-invoker-plugin/usage.html -->
<configuration>
<mavenOpts>-Dscan=false</mavenOpts>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why set it here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some smoke tests are triggering some Maven builds which would publish some build scans.

@maxandersen
Copy link
Member

not great we have to change the code this much (its not a lot but also more than nothing ;) but if no other way to avoid the scan to be submitted I guess we have to go for this approach.

I would have preferred a way to detect it in the groovy rules.

but +1 on this if no better alternative

@jprinet
Copy link
Contributor Author

jprinet commented Jun 23, 2023

not great we have to change the code this much (its not a lot but also more than nothing ;) but if no other way to avoid the scan to be submitted I guess we have to go for this approach.

I would have preferred a way to detect it in the groovy rules.

but +1 on this if no better alternative

This is the best we have so far if we want to make sure no test builds are published

@jprinet
Copy link
Contributor Author

jprinet commented Jun 23, 2023

Let's pause this for a second, there might be a simpler option using the Groovy script

I convert this PR to draft and propose a new version ASAP

@jprinet jprinet marked this pull request as draft June 23, 2023 13:17
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 23, 2023

Failing Jobs - Building 50a1f35

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 Windows Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 19
✔️ Maven Tests - JDK 11
Maven Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs

@jprinet
Copy link
Contributor Author

jprinet commented Jun 27, 2023

Closing in favor of #34335

@jprinet jprinet closed this Jun 27, 2023
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/jbang Issues related to when using jbang.dev with Quarkus area/kotlin area/kubernetes area/maven area/scala area/testing triage/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants