Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add summary section for local kubernetes #34157

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

iocanel
Copy link
Contributor

@iocanel iocanel commented Jun 20, 2023

For some people it seems that the options for local kubernetes deployment are not obvious. So, let's add a section that summarizes the options for local kubernetes deployment and leads in to the sections for minikube and kind.

@iocanel iocanel requested a review from geoand June 20, 2023 09:36
@iocanel iocanel force-pushed the doc-local-kubernetes-deployment branch from 10daf16 to 28860dc Compare June 20, 2023 09:50
@github-actions
Copy link

github-actions bot commented Jun 20, 2023

🙈 The PR is closed and the preview is expired.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted a few things that need fixing.

docs/src/main/asciidoc/deploying-to-kubernetes.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/deploying-to-kubernetes.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/deploying-to-kubernetes.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/deploying-to-kubernetes.adoc Outdated Show resolved Hide resolved
@iocanel iocanel force-pushed the doc-local-kubernetes-deployment branch from a8c8a85 to 745b62b Compare June 22, 2023 09:53
@iocanel
Copy link
Contributor Author

iocanel commented Jun 22, 2023

@gsmet: applied your commits and squashed them. Thanks!

@iocanel iocanel requested a review from gsmet June 29, 2023 06:58
@iocanel iocanel force-pushed the doc-local-kubernetes-deployment branch from 745b62b to b5bd4f9 Compare July 26, 2023 09:33
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks!

@gsmet gsmet force-pushed the doc-local-kubernetes-deployment branch from b5bd4f9 to 7280f6f Compare September 22, 2023 14:28
@gsmet gsmet merged commit e6ea6d5 into quarkusio:main Sep 22, 2023
3 of 5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.5 - main milestone Sep 22, 2023
@gsmet
Copy link
Member

gsmet commented Sep 22, 2023

I squashed the commits before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants