Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArC: add synthetic interceptors API #34138

Merged
merged 1 commit into from
Jun 21, 2023
Merged

ArC: add synthetic interceptors API #34138

merged 1 commit into from
Jun 21, 2023

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jun 19, 2023 •
edited
Loading

  • add tests for other interception types

@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Jun 19, 2023
@mkouba mkouba requested review from manovotn and Ladicek June 19, 2023 16:08
@quarkus-bot

This comment has been minimized.

Sign in to view
@Ladicek
Copy link
Contributor

Ladicek commented Jun 20, 2023

LGTM, but tests for other interceptor types should indeed be added.

@quarkus-bot

This comment has been minimized.

Sign in to view
@mkouba mkouba force-pushed the synthetic-interceptors branch from 0c2c40e to 2161015 Compare June 20, 2023 19:45
@mkouba mkouba requested review from Ladicek and manovotn June 20, 2023 19:45
@mkouba
Copy link
Contributor Author

mkouba commented Jun 20, 2023

LGTM, but tests for other interceptor types should indeed be added.

And done ;-).

@mkouba mkouba force-pushed the synthetic-interceptors branch from 2161015 to 0938a97 Compare June 20, 2023 20:03
@mkouba mkouba force-pushed the synthetic-interceptors branch from 0938a97 to f5994eb Compare June 20, 2023 20:04
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 21, 2023

Failing Jobs - Building f5994eb

Status Name Step Failures Logs Raw logs
✖ Native Tests - Windows - RESTEasy Jackson Setup GraalVM ⚠️ Check → Logs Raw logs

@mkouba mkouba added this to the 3.3 - main milestone Jun 21, 2023
@Ladicek
Copy link
Contributor

Ladicek commented Jun 21, 2023

Nice!

manovotn
manovotn approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mkouba mkouba merged commit 696ada1 into quarkusio:main Jun 21, 2023
@mkouba mkouba mentioned this pull request Aug 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manovotn manovotn manovotn approved these changes

@Ladicek Ladicek Ladicek approved these changes

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection)
Projects
None yet
Milestone
3.3.0.CR1
Development

Successfully merging this pull request may close these issues.
3 participants
@mkouba @Ladicek @manovotn