-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QuarkusComponentTest: convenient handling of nested classes #34127
Conversation
This PR partially solves #34086. |
...5-component/src/test/java/io/quarkus/test/component/declarative/IgnoreNestedClassesTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise.
- add static nested classes declared on test class to the set of components under test by default - exclude static nested classes declated on a QuarkusComponentTest from discovery during `@QuarkusTest`
4900808
to
f651231
Compare
This comment has been minimized.
This comment has been minimized.
Failing Jobs - Building f651231
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 17 Windows #- Failing: extensions/vertx/deployment
! Skipped: extensions/agroal/deployment extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment and 365 more 📦 extensions/scheduler/deployment✖
📦 extensions/vertx/deployment✖
✖
|
@QuarkusTest