Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuarkusComponentTest: convenient handling of nested classes #34127

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jun 19, 2023

  • add static nested classes declared on test class to the set of components under test by default
  • exclude static nested classes declated on a QuarkusComponentTest from discovery during @QuarkusTest

@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/testing labels Jun 19, 2023
@mkouba
Copy link
Contributor Author

mkouba commented Jun 19, 2023

This PR partially solves #34086.

@mkouba mkouba requested review from Ladicek and holly-cummins June 19, 2023 10:14
@mkouba mkouba added this to the 3.2 - main milestone Jun 19, 2023
Copy link
Contributor

@Ladicek Ladicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise.

- add static nested classes declared on test class to the set of
  components under test by default
- exclude static nested classes declated on a QuarkusComponentTest from
  discovery during `@QuarkusTest`
@mkouba mkouba force-pushed the component-nested-classes branch from 4900808 to f651231 Compare June 19, 2023 10:37
@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 19, 2023
@quarkus-bot

This comment has been minimized.

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 19, 2023

Failing Jobs - Building f651231

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 19
✔️ Maven Tests - JDK 11
Maven Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
Native Tests - Windows - RESTEasy Jackson Setup GraalVM ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 Windows #

- Failing: extensions/vertx/deployment 
! Skipped: extensions/agroal/deployment extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment and 365 more

📦 extensions/scheduler/deployment

io.quarkus.scheduler.test.PausedSchedulerTest.testSchedulerPauseResume line 47 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <false> but was: <true>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

📦 extensions/vertx/deployment

io.quarkus.vertx.mdc.VertxMDCTest.mdc line 144 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <10> but was: <0>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

io.quarkus.vertx.mdc.VertxMDCTest.mdcNonVertxThreadTest line 121 - More details - Source on GitHub

java.lang.AssertionError: 

Expected: a collection containing "Test MDC value ### Test 1"

@gsmet gsmet merged commit 297c0ca into quarkusio:main Jun 20, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) area/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants