Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not fail the build if wait for tags fails #34122

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Do not fail the build if wait for tags fails #34122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ...ent/src/main/java/io/quarkus/container/image/openshift/deployment/OpenshiftProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,8 +411,13 @@ private static void applyOpenshiftResources(OpenShiftClient client, List<HasMeta
deployResource(client, i);
LOG.info("Applied: " + i.getKind() + " " + i.getMetadata().getName());
}
OpenshiftUtils.waitForImageStreamTags(client, buildResources, 2, TimeUnit.MINUTES);

try {
OpenshiftUtils.waitForImageStreamTags(client, buildResources, 2, TimeUnit.MINUTES);
} catch (KubernetesClientException e) {
//User may not have permission to get / list `ImageStreamTag` or this step may fail for any reason.
//As this is not an integral part of the build we should catch and log.
LOG.debug("Waiting for ImageStream tag failed. Ignoring.");
}
} catch (KubernetesClientException e) {
KubernetesClientErrorHandler.handle(e);
}
Expand Down