Update builder images to jdk-17.0.7 #34120

cescoffier · 2023-06-19T06:32:30Z

Update the GraalVM Community builder image to the tag jdk-17 / jdk-17.0.7
Update the Mandrel builder image to the tag jdk-17(Mandrel 23.0)
Update GraalVM SDK version to 23.0 (yes, it does not follow the same version scheme)

Note that the version scheme and name also changed: GraalVM CE -> GraalVM Community. We kept the name of the image unchanged to avoid a massive breaking change.

cescoffier · 2023-06-19T06:34:22Z

(pinging @Karm instead of @zakkak (in PTO if I'm correct)).

@geoand / @Karm / @gsmet I'm wondering about the io.quarkus.deployment.pkg.steps.GraalVM class:

java 11 as default (shouldn't it be 17)
uses the old version schema, it's fine for now, but might become confusing in a few months

cescoffier · 2023-06-19T06:35:07Z

Note - unrelated to that PR, I've also deprecated the native S2i (which included Maven / Gradle...).

(FYI: @tqvarnst and @maxandersen)

cescoffier · 2023-06-19T06:35:49Z

@Karm seems like the AWT substitutions would need some love (see the documentation build).

maxandersen

You mention the image is deprecated...but it does not seem explicitly called out/mentioned anywhere ?

maxandersen · 2023-06-19T06:38:18Z

docs/pom.xml

@@ -17,8 +17,8 @@
    <properties>
        <!-- The Graal version we suggest using in documentation - as that's
           what we work with by self downloading it: -->
-        <graal-sdk.version-for-documentation>22.3</graal-sdk.version-for-documentation>


Is this really necessary to change everywhere ? I'm here thinking of handling updates/backports of docs.

Maybe not a super big deal but just wondering why change this perfectly valid key?

Because we use that variable to indicate where to download the GraalVM Community packages, and we want to recommend jdk-17.0.7 (aka 23.0)

geoand · 2023-06-19T06:40:10Z

@geoand / @Karm / @gsmet I'm wondering about the io.quarkus.deployment.pkg.steps.GraalVM class:

java 11 as default (shouldn't it be 17)

uses the old version schema, it's fine for now, but might become confusing in a few months

I would say, let's fix this properly once 3.2 is out and we have more time and won't be affected by people being off

cescoffier · 2023-06-19T06:43:12Z

@maxandersen

You mention the image is deprecated...but it does not seem explicitly called out/mentioned anywhere ?

That's the good news: the Quarkus codebase does not reference that image (but it's still pulled a lot...). I've updated the description on Quay. See https://quay.io/repository/quarkus/ubi-quarkus-graalvmce-s2i (let me know if you don't have access to the usage log)

cescoffier · 2023-06-19T06:47:47Z

@maxandersen @Karm is it expected that the new SDK is compiled with Java 17 - which obviously will break our java 11 support.

maxandersen · 2023-06-19T07:01:36Z

is it expected that the new SDK is compiled with Java 17 - which obviously will break our java 11 support.

breaks some build components I reckon or do we have an actual runtime/just-for-java-not-native-image dependency on this?

maxandersen · 2023-06-19T07:47:30Z

independent-projects/bootstrap/pom.xml

@@ -71,7 +71,7 @@
        <jboss-logmanager-embedded.version>1.0.11</jboss-logmanager-embedded.version>
        <slf4j-jboss-logmanager.version>1.1.0.Final</slf4j-jboss-logmanager.version>
        <slf4j-api.version>1.7.36</slf4j-api.version>
-        <graal-sdk.version>22.3.2</graal-sdk.version>
+        <graal-sdk.version>23.0.0</graal-sdk.version>


this makes it only build on java 11.
afaics it only brings in the annotations - that library shouldn't be java 17 bound IMO.

I've pinged on graalvm slack what their recommendation is.

In worst case we stay on the old version for this as it just brings substitution annotations.

imo we should for now stay on 22.3.2 for the jar dependency - then we at least can kick of right testing etc.

one piece of evidence to stay on 22.3.2 is that there are no API differences:
https://diff.revapi.org/?groupId=org.graalvm.sdk&artifactId=graal-sdk&old=22.3.2&new=23.0.0

github-actions · 2023-06-19T09:02:19Z

🙈 The PR is closed and the preview is expired.

gsmet · 2023-06-20T07:00:51Z

core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/GraalVM.java

        public static final Version VERSION_22_3_0 = new Version("GraalVM 22.3.0", "22.3.0", Distribution.ORACLE);
        public static final Version VERSION_22_2_0 = new Version("GraalVM 22.2.0", "22.2.0", Distribution.ORACLE);
        public static final Version VERSION_23_0_0 = new Version("GraalVM 23.0.0", "23.0.0", Distribution.ORACLE);
        public static final Version VERSION_23_1_0 = new Version("GraalVM 23.1.0", "23.1.0", Distribution.ORACLE);

        public static final Version MINIMUM = VERSION_22_2_0;
-        public static final Version CURRENT = VERSION_22_3_2;
+        public static final Version CURRENT = VERSION_23_0_0;


Are we going to detect the version correctly with the new version scheme? Or GraalVM still has 23 in the version string? My recollection is that you said it doesn't.

Yes, that's a problem. I mentioned this in the PR description. I believe the class needs to be adjusted.

jerboaa · 2023-06-20T09:05:11Z

core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/GraalVM.java

-            if (linesList.size() == 3) {
+        static Version of(Stream<String> output) {
+            List<String> lines = output
+                    .dropWhile(l -> !l.startsWith("GraalVM") && !l.startsWith("native-image"))


@gsmet How is this not dropping lines of the form (third line in the new output):

Substrate VM GraalVM CE 20.0.1+9.1 (build 20.0.1+9, serial gc)

and

OpenJDK Runtime Environment Mandrel-23.0.0.0-Final (build 17.0.7+7)

What am I missing?

I think the safer option is to pull the image before running --version on it.

@jerboaa it's dropWhile: it's dropping the lines while the condition is true, then it keeps all the lines.

As for changing entirely the way it is done, I'm not comfortable to do it now but could be convinced for a future version.

FWIW, I discovered this method today while implementing this :).

@gsmet Gotcha. Fair enough then.

Karm · 2023-06-20T11:48:45Z

@Karm seems like the AWT substitutions would need some love (see the documentation build).

@cescoffier Could you be more specific, please? The doc build log seem ok...?

cescoffier · 2023-06-20T11:50:15Z

No, I was suspecting a problem, but it was due to the broken version detection

- Update the GraalVM Community builder image to the tag `jdk-17` / `jdk-17.0.7` - Update the Mandrel builder image to the tag `jdk-17`(Mandrel 23.0) - Update GraalVM SDK version to 23.0 (yes, it does not follow the same version scheme) Note that the version scheme and name also changed: GraalVM CE -> GraalVM Community. We kept the name of the image unchanged to avoid a massive breaking change.

It's a hack because the new jar use Java 17 bytecode. We would need to be sure that this version is not used for anything more than the SVM artifact version.

We need to filter the output coming from Docker downloading the image.

We decided to merge it.

gsmet

LGTM, I restarted a CI run with some adjusted timeouts. I'll merge this evening.

quarkus-bot · 2023-06-20T21:08:58Z

Failing Jobs - Building `ccd299f`

Status	Name	Step	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 11
⌛	JVM Tests - JDK 17	`Build`	⚠️ Check →	Logs	Raw logs
✔️	JVM Tests - JDK 19
✖	Native Tests - Windows - RESTEasy Jackson	`Setup GraalVM`	⚠️ Check →	Logs	Raw logs

cescoffier requested review from zakkak, gsmet and Karm and removed request for zakkak June 19, 2023 06:32

quarkus-bot bot added area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation labels Jun 19, 2023

This comment has been minimized.

Sign in to view

maxandersen previously requested changes Jun 19, 2023

View reviewed changes

maxandersen reviewed Jun 19, 2023

View reviewed changes

cescoffier force-pushed the graalvm-june-2023-update branch from 35fa7cf to fd7b2b2 Compare June 19, 2023 08:18

This comment has been minimized.

Sign in to view

cescoffier force-pushed the graalvm-june-2023-update branch from fd7b2b2 to 96e1889 Compare June 20, 2023 05:49

gsmet reviewed Jun 20, 2023

View reviewed changes

jerboaa reviewed Jun 20, 2023

View reviewed changes

cescoffier added 2 commits June 20, 2023 16:02

Revert the GraalVM SDK to 22.3.2

9614834

It's a hack because the new jar use Java 17 bytecode. We would need to be sure that this version is not used for anything more than the SVM artifact version.

gsmet added 2 commits June 20, 2023 16:02

Fix version detection when the image is downloaded for the first time

c16b84f

We need to filter the output coming from Docker downloading the image.

Adjust some native builds timeouts

ccd299f

gsmet force-pushed the graalvm-june-2023-update branch from 5fe6d49 to ccd299f Compare June 20, 2023 14:04

quarkus-bot bot added the area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure label Jun 20, 2023

gsmet approved these changes Jun 20, 2023

View reviewed changes

gsmet added this to the 3.2 - main milestone Jun 20, 2023

gsmet merged commit 2a029d9 into quarkusio:main Jun 21, 2023

turing85 mentioned this pull request Jun 26, 2023

Initialize build runner in AwtProcessor before usage #34296

Merged

cescoffier deleted the graalvm-june-2023-update branch July 3, 2023 07:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update builder images to jdk-17.0.7 #34120

Update builder images to jdk-17.0.7 #34120

cescoffier commented Jun 19, 2023

cescoffier commented Jun 19, 2023

cescoffier commented Jun 19, 2023

cescoffier commented Jun 19, 2023

This comment has been minimized.

maxandersen left a comment

maxandersen Jun 19, 2023

cescoffier Jun 19, 2023

geoand commented Jun 19, 2023 •

edited

Loading

cescoffier commented Jun 19, 2023

cescoffier commented Jun 19, 2023

maxandersen commented Jun 19, 2023

maxandersen Jun 19, 2023

maxandersen Jun 19, 2023

maxandersen Jun 19, 2023

github-actions bot commented Jun 19, 2023 •

edited

Loading

This comment has been minimized.

gsmet Jun 20, 2023

cescoffier Jun 20, 2023

jerboaa Jun 20, 2023

jerboaa Jun 20, 2023

gsmet Jun 20, 2023

gsmet Jun 20, 2023

gsmet Jun 20, 2023

jerboaa Jun 20, 2023

Karm commented Jun 20, 2023

cescoffier commented Jun 20, 2023

gsmet left a comment

quarkus-bot bot commented Jun 20, 2023

Update builder images to jdk-17.0.7 #34120

Update builder images to jdk-17.0.7 #34120

Conversation

cescoffier commented Jun 19, 2023

cescoffier commented Jun 19, 2023

cescoffier commented Jun 19, 2023

cescoffier commented Jun 19, 2023

This comment has been minimized.

maxandersen left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

geoand commented Jun 19, 2023 • edited Loading

cescoffier commented Jun 19, 2023

cescoffier commented Jun 19, 2023

maxandersen commented Jun 19, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jun 19, 2023 • edited Loading

This comment has been minimized.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Karm commented Jun 20, 2023

cescoffier commented Jun 20, 2023

gsmet left a comment

Choose a reason for hiding this comment

quarkus-bot bot commented Jun 20, 2023

Failing Jobs - Building ccd299f

geoand commented Jun 19, 2023 •

edited

Loading

github-actions bot commented Jun 19, 2023 •

edited

Loading

Failing Jobs - Building `ccd299f`