Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Hibernate ORM to 6.2.5.Final and Reactive to 2.0.1.Final #34058

Closed
wants to merge 1 commit into from

Conversation

DavideD
Copy link
Contributor

@DavideD DavideD commented Jun 15, 2023

  • Hibernate ORM to 6.2.5.Final
  • Hibernate Reactive to 2.0.1.Final

* Hibernate ORM to 6.2.5.Final
* Hibernate Reactive to 2.0.1.Final
@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/hibernate-reactive Hibernate Reactive area/persistence OBSOLETE, DO NOT USE labels Jun 15, 2023
@gsmet gsmet changed the title Upgrade Hibernate Reactive and ORM Upgrade Hibernate ORM to 6.2.5.Final and Reactive to 2.0.1.Final Jun 15, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 15, 2023

Failing Jobs - Building 5cb713f

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
JVM Tests - JDK 17 Build Failures Logs Raw logs
JVM Tests - JDK 17 Windows Build Failures Logs Raw logs
JVM Tests - JDK 19 Build Failures Logs Raw logs
✔️ Maven Tests - JDK 11
Maven Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
Native Tests - Spring Build Failures Logs Raw logs
Native Tests - Windows - RESTEasy Jackson Setup GraalVM ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/reactive-messaging-hibernate-orm integration-tests/reactive-messaging-hibernate-reactive integration-tests/spring-data-jpa 

📦 integration-tests/reactive-messaging-hibernate-orm

io.quarkus.it.kafka.KafkaConnectorTest.testPeople line 70 - More details - Source on GitHub

java.lang.RuntimeException: 
com.fasterxml.jackson.databind.JsonMappingException: Object of type 'class io.quarkus.smallrye.reactivemessaging.kafka.CheckpointEntityId' can't be cast to CompositeTracker
 at [Source: (String)"{"id":{"consumerGroupId":"people-checkpoint","topic":"people","partition":0},"offset":6,"names":"bob;alice;tom;jerry;anna;ken"}"; line: 1, column: 76] (through reference chain: io.quarkus.it.kafka.people.PeopleState["id"])

📦 integration-tests/reactive-messaging-hibernate-reactive

io.quarkus.it.kafka.KafkaConnectorTest.testPeople line 60 - More details - Source on GitHub

java.lang.RuntimeException: 
com.fasterxml.jackson.databind.JsonMappingException: Object of type 'class io.quarkus.smallrye.reactivemessaging.kafka.CheckpointEntityId' can't be cast to CompositeTracker
 at [Source: (String)"{"id":{"consumerGroupId":"people-checkpoint","topic":"people","partition":0},"offset":6,"names":"bob;alice;tom;jerry;anna;ken"}"; line: 1, column: 76] (through reference chain: io.quarkus.it.kafka.PeopleState["id"])

📦 integration-tests/spring-data-jpa

io.quarkus.it.spring.data.jpa.PhoneCallResourceTest.testFindById line 16 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/amazon-lambda/deployment integration-tests/reactive-messaging-hibernate-orm integration-tests/reactive-messaging-hibernate-reactive and 1 more
! Skipped: extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment integration-tests/amazon-lambda and 6 more

📦 extensions/amazon-lambda/deployment

io.quarkus.amazon.lambda.deployment.testing.LambdaDevServicesContinuousTestingTestCase.testLambda line 48 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <1> but was: <0>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

📦 integration-tests/reactive-messaging-hibernate-orm

io.quarkus.it.kafka.KafkaConnectorTest.testPeople line 70 - More details - Source on GitHub

java.lang.RuntimeException: 
com.fasterxml.jackson.databind.JsonMappingException: Object of type 'class io.quarkus.smallrye.reactivemessaging.kafka.CheckpointEntityId' can't be cast to CompositeTracker
 at [Source: (String)"{"id":{"consumerGroupId":"people-checkpoint","topic":"people","partition":0},"offset":6,"names":"bob;alice;tom;jerry;anna;ken"}"; line: 1, column: 76] (through reference chain: io.quarkus.it.kafka.people.PeopleState["id"])

📦 integration-tests/reactive-messaging-hibernate-reactive

io.quarkus.it.kafka.KafkaConnectorTest.testPeople line 60 - More details - Source on GitHub

java.lang.RuntimeException: 
com.fasterxml.jackson.databind.JsonMappingException: Object of type 'class io.quarkus.smallrye.reactivemessaging.kafka.CheckpointEntityId' can't be cast to CompositeTracker
 at [Source: (String)"{"id":{"consumerGroupId":"people-checkpoint","topic":"people","partition":0},"offset":6,"names":"bob;alice;tom;jerry;anna;ken"}"; line: 1, column: 76] (through reference chain: io.quarkus.it.kafka.PeopleState["id"])

📦 integration-tests/spring-data-jpa

io.quarkus.it.spring.data.jpa.PhoneCallResourceTest.testFindById line 16 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

⚙️ JVM Tests - JDK 17 Windows #

- Failing: integration-tests/spring-data-jpa 

📦 integration-tests/spring-data-jpa

io.quarkus.it.spring.data.jpa.PhoneCallResourceTest.testFindById line 16 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

⚙️ JVM Tests - JDK 19 #

- Failing: integration-tests/reactive-messaging-hibernate-orm integration-tests/reactive-messaging-hibernate-reactive integration-tests/spring-data-jpa 

📦 integration-tests/reactive-messaging-hibernate-orm

io.quarkus.it.kafka.KafkaConnectorTest.testPeople line 70 - More details - Source on GitHub

java.lang.RuntimeException: 
com.fasterxml.jackson.databind.JsonMappingException: Object of type 'class io.quarkus.smallrye.reactivemessaging.kafka.CheckpointEntityId' can't be cast to CompositeTracker
 at [Source: (String)"{"id":{"consumerGroupId":"people-checkpoint","topic":"people","partition":0},"offset":6,"names":"bob;alice;tom;jerry;anna;ken"}"; line: 1, column: 76] (through reference chain: io.quarkus.it.kafka.people.PeopleState["id"])

📦 integration-tests/reactive-messaging-hibernate-reactive

io.quarkus.it.kafka.KafkaConnectorTest.testPeople line 60 - More details - Source on GitHub

java.lang.RuntimeException: 
com.fasterxml.jackson.databind.JsonMappingException: Object of type 'class io.quarkus.smallrye.reactivemessaging.kafka.CheckpointEntityId' can't be cast to CompositeTracker
 at [Source: (String)"{"id":{"consumerGroupId":"people-checkpoint","topic":"people","partition":0},"offset":6,"names":"bob;alice;tom;jerry;anna;ken"}"; line: 1, column: 76] (through reference chain: io.quarkus.it.kafka.PeopleState["id"])

📦 integration-tests/spring-data-jpa

io.quarkus.it.spring.data.jpa.PhoneCallResourceTest.testFindById line 16 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

⚙️ Native Tests - Spring #

- Failing: integration-tests/spring-data-jpa 

📦 integration-tests/spring-data-jpa

Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project quarkus-integration-test-spring-data-jpa: Failed to build quarkus application

@gsmet
Copy link
Member

gsmet commented Jun 16, 2023

Unfortunately, this doesn't look good. My testing didn't go this far unfortunately. We really need to figure out a way to test these snapshots fully on CI.

/cc @dreab8 @Sanne

@gsmet
Copy link
Member

gsmet commented Jun 16, 2023

Kafka error:

Caused by: java.lang.ClassCastException: Object of type 'class io.quarkus.smallrye.reactivemessaging.kafka.CheckpointEntityId' can't be cast to CompositeTracker
	at org.hibernate.engine.internal.ManagedTypeHelper.asCompositeTracker(ManagedTypeHelper.java:337)
	at io.quarkus.it.kafka.people.PeopleState.$$_hibernate_write_id(PeopleState.java)
	at io.quarkus.smallrye.reactivemessaging.kafka.CheckpointEntity.setId(CheckpointEntity.java:56)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at com.fasterxml.jackson.databind.deser.impl.MethodProperty.deserializeAndSet(MethodProperty.java:141)
	... 25 more

Spring Data JPA error:

	Caused by: java.lang.NoSuchMethodError: 'io.quarkus.it.spring.data.jpa.PhoneCallId io.quarkus.it.spring.data.jpa.AbstractPhoneEntity.$$_hibernate_read_id()'
		at io.quarkus.it.spring.data.jpa.PhoneCall.$$_hibernate_write_id(PhoneCall.java)
		at io.quarkus.it.spring.data.jpa.AbstractTypedIdEntity.<init>(AbstractTypedIdEntity.java:16)
		at io.quarkus.it.spring.data.jpa.AbstractPhoneEntity.<init>(AbstractPhoneEntity.java:10)
		at io.quarkus.it.spring.data.jpa.PhoneCall.<init>(PhoneCall.java:17)
		... 83 more
	Suppressed: org.jboss.resteasy.spi.UnhandledException: org.hibernate.InstantiationException: Could not instantiate entity : io.quarkus.it.spring.data.jpa.PhoneCall
		at org.jboss.resteasy.core.ExceptionHandler.handleApplicationException(ExceptionHandler.java:107)
		at org.jboss.resteasy.core.ExceptionHandler.handleException(ExceptionHandler.java:344)
		at org.jboss.resteasy.core.SynchronousDispatcher.writeException(SynchronousDispatcher.java:205)
		at org.jboss.resteasy.core.SynchronousDispatcher.invoke(SynchronousDispatcher.java:452)
		at org.jboss.resteasy.core.SynchronousDispatcher.lambda$invoke$4(SynchronousDispatcher.java:240)
		at org.jboss.resteasy.core.SynchronousDispatcher.lambda$preprocess$0(SynchronousDispatcher.java:154)
		at org.jboss.resteasy.core.interception.jaxrs.PreMatchContainerRequestContext.filter(PreMatchContainerRequestContext.java:321)
		at org.jboss.resteasy.core.SynchronousDispatcher.preprocess(SynchronousDispatcher.java:157)
		at org.jboss.resteasy.core.SynchronousDispatcher.invoke(SynchronousDispatcher.java:229)
		at io.quarkus.resteasy.runtime.standalone.RequestDispatcher.service(RequestDispatcher.java:82)
		at io.quarkus.resteasy.runtime.standalone.VertxRequestHandler.dispatch(VertxRequestHandler.java:147)
		at io.quarkus.resteasy.runtime.standalone.VertxRequestHandler$1.run(VertxRequestHandler.java:93)
		at io.quarkus.vertx.core.runtime.VertxCoreRecorder$14.runWith(VertxCoreRecorder.java:576)
		at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2513)
		at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1538)
		at org.jboss.threads.DelegatingRunnable.run(DelegatingRunnable.java:29)
		at org.jboss.threads.ThreadLocalResettingRunnable.run(ThreadLocalResettingRunnable.java:29)
		at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
		at java.base/java.lang.Thread.run(Thread.java:829)

/cc @yrodiere too

@Sanne
Copy link
Member

Sanne commented Jun 16, 2023

Thanks for highlighting the errors!

Both errors look like related to a failure of entity enhancement.

@yrodiere
Copy link
Member

Both errors look like related to a failure of entity enhancement.

Agreed. The first one looks like a regression in ORM, the second one might be a combination of a change in ORM and a bug introduced by my earlier PR.

I can't look into this right now, but I'll try to investigate next week.

@DavideD DavideD closed this Jun 19, 2023
@DavideD DavideD deleted the hr-2.0.1.Final branch June 19, 2023 09:32
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Jun 19, 2023
@DavideD
Copy link
Contributor Author

DavideD commented Jun 19, 2023

Oops.... I've deleted this branch by mistake.

Here's a new PR rebased to the latest changes: #34124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/hibernate-reactive Hibernate Reactive area/persistence OBSOLETE, DO NOT USE triage/invalid This doesn't seem right
Projects
None yet
4 participants